Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT-5255 - Update S12_PROTO_VERSION #157

Merged
merged 2 commits into from
Jul 8, 2024
Merged

UT-5255 - Update S12_PROTO_VERSION #157

merged 2 commits into from
Jul 8, 2024

Conversation

xon52
Copy link
Contributor

@xon52 xon52 commented Jul 8, 2024

Summary

Update S12_PROTO_VERSION

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@xon52 xon52 requested a review from a team as a code owner July 8, 2024 00:47
@xon52 xon52 requested a review from HarryTranAU July 8, 2024 00:47
lachlancooper
lachlancooper requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@lachlancooper lachlancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to bump the version in protoc-go/version.txt.

@xon52 xon52 merged commit ca9322b into main Jul 8, 2024
9 checks passed
@xon52 xon52 deleted the UT-5255 branch July 8, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarryTranAU HarryTranAU HarryTranAU approved these changes

@lachlancooper lachlancooper lachlancooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xon52 @lachlancooper @HarryTranAU