Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : post와 comment 응답에 user id를 포함하도록 수정 #167

Merged
merged 2 commits into from
Dec 17, 2023
Merged

feat : post와 comment 응답에 user id를 포함하도록 수정 #167

merged 2 commits into from
Dec 17, 2023

Conversation

kshired
Copy link
Member

@kshired kshired commented Dec 17, 2023

Issue Number

close: # N/A

작업 내역

구현 내용 및 작업 했던 내역

  • post와 comment 응답에 user id를 포함하도록 수정
  • comment 응답을 생성시간 오름차순으로 전달하도록 수정

변경사항

  • 의존성 목록

작업 유형

  • 신규 기능 추가
  • 버그 수정
  • 리펙토링
  • 문서 업데이트

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

@kshired kshired requested a review from ekzm8523 December 17, 2023 09:55
@kshired kshired added the enhancement New feature or request label Dec 17, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kshired kshired temporarily deployed to commit December 17, 2023 09:57 Inactive
ekzm8523
ekzm8523 reviewed Dec 17, 2023
View reviewed changes
src/main/kotlin/io/csbroker/apiserver/controller/v1/post/response/PostResponseDto.kt
username = post.user.username,
likeCount = likeCount,
isLiked = isLiked,
comments = comments,
comments = comments.sortedBy { it.createdAt },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오더링 디테일 좋네요👍

ekzm8523
ekzm8523 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@ekzm8523 ekzm8523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨5

@kshired kshired merged commit 57fa5bb into dev Dec 17, 2023
5 checks passed
@kshired kshired deleted the feat-add-user-id branch December 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekzm8523 ekzm8523 ekzm8523 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshired @ekzm8523