Remove the --cs/--skip arguments and add an example of negative regex #74
Conversation
|
@vmezzela done, removed the |
|
My bad, the issue was fixed in #73 |
|
Is this a reviewed-by tag? :) |
There was a problem hiding this comment.
Don't forget to remove --cs from log command :)
| @@ -588,11 +589,12 @@ def create_lp_package(self, i, cs): | |||
|
|
|||
| logging.info(f"({i}/{self.total}) {cs.name()} done") | |||
|
|
|||
| def log(self, cs, arch): | |||
| def log(self, arch): | |||
There was a problem hiding this comment.
FWIW log now is able to download logs for more than one codestream (e.g. "15.6u1|15.6u2"), but it crashes if I pass "15.6u[1-2]". Up for debate but maybe it would wise to restrict it to just one codestream. I can't think of a scenario in which we would need more that one log. Ideas?
There was a problem hiding this comment.
One possible approach could be to always require a mandatory argument for this command, specifying the name of the codestream whose log is needed (not necessarily in this PR)
| args = [] | ||
| def cs_diff(self): | ||
| """ | ||
| To compare two codestreams the filter should result in exactly two codestreams |
There was a problem hiding this comment.
Hi, I think it would be a good idea to print which codestream is used as base for the diff. I mean, if I pass --filter "15.6u[1-2]", probably u1 will be used as base, but is just a guess.
Perhaps we could do something like :
--- 15.6u1
+++ 15.6u2
What do you think?
There was a problem hiding this comment.
What about the following?
--- 15.5u9 net/ipv4/tcp_input.c
+++ 15.6u0 net/ipv4/tcp_input.c
I've implemented this on the last update.
|
Oops... I implemented the fixes on top of last commit... it's no a big deal, but I don't think it's a problem :) |
Signed-off-by: Marcos Paulo de Souza <[email protected]>
There is an example in the manpage about how to avoid a codestream using a negative regex. Signed-off-by: Marcos Paulo de Souza <[email protected]>
No description provided.