-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SBL-150] object class로의 리팩터링 #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeongHunHui
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
체크리스트 다 잘 작동합니다! 코드도 LGTM입니다~
143a88d
to
b1545ca
Compare
테스트 커버리지 리포트
|
JeongHunHui
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새로 추가된 변경사항도 잘 적용되었습니다~ 고생하셨습니다!
테스트 커버리지 리포트
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 설명
프로퍼티 없이 companion object만 사용하는 클래스를 object 클래스로 변경
+) 시큐리티에 로그인 한 유저만
api/v1/ai/**
에 요청 보낼 수 있게하는 설정 추가✅ 체크 리스트
(프론트엔드 페이제를 이용하여 테스트하면 편리합니다)
/api/v1/admin/sessions/logged-in-users
로 조회시 로그아웃된 그 계정이 조회되지 않는지 확인명령 보냈을 때
수신되는지 확인
요청 보냈을 때
수신되는지 확인