Final fix of minor coding issues from Codacy

STAMP-project · Nov 18, 2019 · bb4a0ef · bb4a0ef
1 parent 0dd824a
commit bb4a0ef
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/camp/entities/model.py b/camp/entities/model.py
@@ -385,7 +385,7 @@ def __eq__(self, other):
 
 
     def __hash__(self):
-        return hash(tuple([self._destination, *self._resources]))
+        return hash(tuple([self._destination] + self._resources))
 
 
     def __repr__(self):

diff --git a/camp/entities/validation.py b/camp/entities/validation.py
@@ -106,7 +106,7 @@ class NoSuchInterface(Error):
     HINT = "Do we miss a {} {}, maybe a component?"
 
     def __init__(self, kind, component, interface, role):
-        super(NoFeatureInterface, self).__init__(
+        super(NoSuchInterface, self).__init__(
             self.PROBLEM.format(kind,
                                 interface.name,
                                 role,

diff --git a/tests/unit/codecs/test_yaml_validation.py b/tests/unit/codecs/test_yaml_validation.py
@@ -15,7 +15,6 @@
 from camp.codecs.yaml import YAML, InvalidYAMLModel
 from camp.entities.model import DockerFile, DockerImage, Substitution, \
     TestSettings
-from camp.entities.report import FailedTest
 
 from unittest import TestCase
 

diff --git a/tests/unit/realize/test_operators.py b/tests/unit/realize/test_operators.py
@@ -47,7 +47,6 @@ def test_handle_files(self):
         self.generate_all()
         self.realize()
 
-        configurations = self.scenario.generated_configurations
         for each_configuration in self.scenario.generated_configurations:
             self._assert_generated(each_configuration, "images/server_0/settings.py")
 
@@ -78,7 +77,6 @@ def test_handle_selecting_without_renaming(self):
         self.generate_all()
         self.realize()
 
-        configurations = self.scenario.generated_configurations
         for each_configuration in self.scenario.generated_configurations:
             if each_configuration.model.resolve("server_0")["proxy"] == "nginx":
                 self._assert_generated(each_configuration,