Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄V2 Card component - added option to embed Youtube videos inside the image text block #3475

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

isaaclombardssw
Copy link
Member

@isaaclombardssw isaaclombardssw commented Jan 10, 2025

SCR-20250110-pjsv SCR-20250110-pjqm

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.19% 69/36167
🔴 Branches 6.12% 24/392
🔴 Functions 0.81% 3/371
🔴 Lines 0.19% 69/36167

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 59a2985

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3475.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 75
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3475.azurewebsites.net

@isaaclombardssw isaaclombardssw changed the title adding a video embed option 💄V2 Card component - added option to embed Youtube videos inside the image text block Jan 10, 2025
@isaaclombardssw isaaclombardssw enabled auto-merge (squash) January 10, 2025 06:51
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3475.azurewebsites.net

@isaaclombardssw isaaclombardssw merged commit b79b021 into main Jan 10, 2025
11 checks passed
@isaaclombardssw isaaclombardssw deleted the video-embeds branch January 10, 2025 07:04
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 78
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3475.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ V2 Components – Video Embed
2 participants