Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DecodeChains function that accepts multiple key bags #63

Closed
wants to merge 3 commits into from
Closed

Implement DecodeChains function that accepts multiple key bags #63

wants to merge 3 commits into from

Conversation

marsskop
Copy link

Resolves #62

@nitram509 nitram509 mentioned this pull request Oct 23, 2024
Open
@nitram509 nitram509 mentioned this pull request Oct 30, 2024
Open
@nitram509
Copy link

FYI:
I tested this branch and found a bug, were duplicates of certificates are in the CA Certificate chain.
Test file shown in here https://github.com/SSLMate/go-pkcs12/blob/c3cfd82538ef72593192d69187daabe6f0339cab/test-data/example_signed_certificates_chain.png
A fix is provided in #65

@marsskop
Copy link
Author

Closing PR as #65 has more relevant fixes.

@marsskop marsskop closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DecodeChains function that accepts multiple key bags
2 participants
@marsskop @nitram509