This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Use rosparam on SimSender #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ROS1実装ではパラメータは
したがって
|
|
This pull request is related to #3 . |
spiralray
force-pushed
the
dev/sim-sender-param
branch
from
7e7e3b0 to
c95bd41
Compare
|
レビュー始めました。 |
|
動作確認しました。 lintは気にせずマージします |
|
cpplint通っててナイスです |
consai2r2_descriptionでパラメータ実装したので #33 がマージされたらそちらに移行するようにissueを立てる必要がありますね |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
フォーマッタかけたので変更が多く見えますが、実際に変わったのは2個目のコミットの方だけです。