feat: error classification #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
jboix
force-pushed
the
feat/error-classification
branch
3 times, most recently
from
c451226 to
b1e7313
Compare
MGaetan89
reviewed
Jan 31, 2025
src/main/kotlin/ch/srgssr/pillarbox/monitoring/event/model/ErrorProcessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/ch/srgssr/pillarbox/monitoring/event/model/ErrorProcessor.kt
Outdated
Show resolved
Hide resolved
Resolves #21 by implementing server-side error classification based on content restrictions and refactoring the deserialization logic into a converter-based strategy: - Errors are now categorized using the new `error_type` field, and a `business_error` flag distinguishes between expected (business) errors and player errors. - Moved from a deserializer-based approach to a converter, enabling a more extensible processing pipeline. - Introduced a processing pipeline to standardize how different processors apply transformations. Co-authored-by: Gaëtan Muller <[email protected]>
jboix
force-pushed
the
feat/error-classification
branch
from
b1e7313 to
939e68d
Compare
MGaetan89
approved these changes
Jan 31, 2025
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #21 by implementing server-side error classification based on content restrictions and refactoring the deserialization logic into a converter-based strategy:
Changes Made
error_typefield, and abusiness_errorflag distinguishes between expected (business) errors and player errors.Checklist