Chewbbaca batch input #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordRust
reviewed
Feb 8, 2023
modules/chewbbaca/main.nf
Outdated
| path input | ||
|
|
||
| output: | ||
| path("${output}") | ||
| tuple val(sampleName), path("${output}") | ||
|
|
||
| script: | ||
| id = "${input.simpleName}" |
There was a problem hiding this comment.
Do we need line 86? Which seems to have the wrong name anyways (simpleName)
There was a problem hiding this comment.
simpleName is a nextflow function that strips extension and filepath base. Regardless, it should be removed as it is old code.
LordRust
reviewed
Feb 8, 2023
LordRust
reviewed
Feb 8, 2023
modules/chewbbaca/main.nf
Outdated
Comment on lines
34
to
37
| trainingFile = trainingFile ? "--ptf ${trainingFile}" : "" | ||
| flockfile = file(params.localTempDir + '/chewbbaca.lock') | ||
| flocking = flockfile.exists() ? "flock -e $flockfile \\" : "" | ||
|
|
There was a problem hiding this comment.
Only a local lock on a single node? Would fail with multiple nodes I think
LordRust
requested changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made: