Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gens v3.0.0 #169

Merged
merged 266 commits into from
Jan 29, 2025
Merged

Gens v3.0.0 #169

merged 266 commits into from
Jan 29, 2025

Conversation

Jakob37
Copy link
Collaborator

@Jakob37 Jakob37 commented Nov 15, 2024

This PR adds a functionality or fixes a bug.
OR
This PR marks a new Gens release. We apply semantic versioning. This is a major/minor/patch release for reasons.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by

Discussion points

  • How to deal with the .github workflows set up by Stockholm? (Working with their instance)
  • Addition of case_id. What consequences? I suspect we will need to migrate our Gens db before merge.
  • Updates to preprocessing scripts generate_gens_data.pl and gvcfvaf.pl. Needs to be tested separately? We are using a different script in the ol' wgs repo?
  • Individual ID used in addition to the sample_id and case_id. What is the significance?
  • Leaving out for now as it is not completed: Start something that would Fix #32 Clinical-Genomics/gens#92
  • The changelog is a mess. Let's see how to organize it.
  • Looks like Gens is merging with Scout through its database. Let's think about how we want to approach that.

Migration steps

  • Update the case_id. Here for a single test sample: db.samples.updateOne({}, {"$set": {"case_id": "hg002"}})
  • Login screen. Make sure it works OK. Seems to look for user email in the Scout db, which should work good enough for now. Do we want to use the same LDAP system as in Scout eventually?

raysloks and others added 30 commits September 30, 2022 12:13
Adds parsing support for common .bed column names
Adds gunicorn default command to dockerfile
Adds docker build and push for master branch
Changes to accurately reflect Gens' WSGI setup
Adds case name as an additional database field
Adds case name to most, if not all, places needed
store_sample logs DuplicateKeyError (no crash)
Adds github action for prod docker image
@Jakob37 Jakob37 changed the title Stockholm transfer (round 2: getting their commits) Stockholm transfer Nov 19, 2024
@Jakob37 Jakob37 changed the base branch from master to current_stockholm_master November 19, 2024 09:31
@Jakob37 Jakob37 self-assigned this Nov 29, 2024
@Jakob37 Jakob37 changed the title Stockholm transfer Gens v3.0.0 Nov 29, 2024
@Jakob37 Jakob37 changed the base branch from current_stockholm_master to master January 27, 2025 06:56
@Jakob37 Jakob37 marked this pull request as ready for review January 29, 2025 06:28
@Jakob37
Copy link
Collaborator Author

Jakob37 commented Jan 29, 2025

This has been tested both by me and Tord. I think it is ready to go.

@Jakob37 Jakob37 merged commit c51c67b into master Jan 29, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants