Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojang changing jar location / MC 1.13+ doesn't work #235

Closed
Grand-Trizmo opened this issue May 8, 2018 · 84 comments
Closed

Mojang changing jar location / MC 1.13+ doesn't work #235

Grand-Trizmo opened this issue May 8, 2018 · 84 comments

Comments

@Grand-Trizmo
Copy link

Grand-Trizmo commented May 8, 2018

image
changing location from amazonaws to their own network as per this dinnerbone tweet
https://twitter.com/Dinnerbone/status/993773511469686784

@sk89q
Copy link
Member

sk89q commented May 14, 2018

Well hopefully it's just a line change in launcher.properties

@Grand-Trizmo
Copy link
Author

It should be I haven’t dug into the new one quite yet maybe this weekend I’ll just make a pr

@Routhinator
Copy link

Two lines in fact:

lines 13-14 of laucher.properties:

jarUrl=https://s3.amazonaws.com/Minecraft.Download/versions/%1$s/%1$s.jar
assetsIndexUrl=https://s3.amazonaws.com/Minecraft.Download/indexes/%s.json

@Routhinator
Copy link

Actually, they are introducing a json manifest, so that will need to be read.

@Routhinator
Copy link

Anyone looked at this yet? I'm trying to learn the code enough (without knowing Java) to make the change.. but maybe theres another repo we can point at that will maintain backwards compatibility?

@sk89q sk89q added the feature label Jul 15, 2018
@Aughen
Copy link

Aughen commented Jul 21, 2018

The 1.13 is also not on the old location as well

@CptWow
Copy link

CptWow commented Jul 28, 2018

I tried doing it myself for 1.13 specifically but I have no experience, I have found some of the new urls to point to but not one for assetsSource, building the pack gives unknown source error so just going to wait patiently now

versionManifestUrl=https://launchermeta.mojang.com/mc/game/version_manifest.json

jarUrl=https://launcher.mojang.com/mc/game/1.13/client/c0b970952cdd279912da384cdbfc0c26e6c6090b/client.jar

assetsIndexUrl=https://launchermeta.mojang.com/mc/game/3132596cced9f9d6f1ca97aeec75651e6a9df0bc/1.13.json

@sk89q
Copy link
Member

sk89q commented Jul 30, 2018

I'll check this out very soon. I rolled my ankle today anyway =) =(

@sk89q sk89q changed the title Mojang changing jar location Mojang changing jar location / MC 1.13+ doesn't work Jul 30, 2018
@workingovertime
Copy link

Could this be fixed really soon? Need it ASAP.

@ColaIan
Copy link

ColaIan commented Sep 17, 2018

me too, please fix it soon!

@Grand-Trizmo
Copy link
Author

bump

@CptWow
Copy link

CptWow commented Oct 7, 2018

Is there any way around this? I have not been able to find anything. Does the launcher source code need a rewrite to read the new location or is it just changing the lines properly in launcher.properties

@Grand-Trizmo
Copy link
Author

@sk89q running out of time on this one

@sk89q
Copy link
Member

sk89q commented Oct 9, 2018

Yeah, well, I've been really busy. out of the country next week too (anyone in Melbourne or Tokyo/Kyoto?)

@CptWow
Copy link

CptWow commented Oct 9, 2018

two places i would very much like to see, take it easy

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

I fixed it in a private forked version.

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

I just cannot seem out how to fix this dependency issue: [LWJGL] Failed to load a library. Possible solutions:

      "-Djava.library.path=${natives_directory}",
      "-Dminecraft.launcher.brand=${launcher_name}",
      "-Dminecraft.launcher.version=${launcher_version}",
      "-cp",
      "${classpath}"```

@sk89q
Copy link
Member

sk89q commented Oct 19, 2018

Hey, a PR would be much appreciated!

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

Hey, a PR would be much appreciated!

Ok, I can try. The code may be sloppy. I'll try to make it as neat as possible.

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

#265 Updated. Let me know if it doesn't work.

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

Hey, a PR would be much appreciated!

I just cannot seem out how to fix this dependency issue: [LWJGL] Failed to load a library. Possible solutions:

      "-Djava.library.path=${natives_directory}",

Do you know how to add that to the startup? I need it to be able to use 1.13. Otherwise it won't load.

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

Completely ignored arguments: [-Djava.library.path=${natives_directory}, -Dminecraft.launcher.brand=${launcher_name}, -Dminecraft.launcher.version=${launcher_version}, -cp, ${classpath}]
[12:05:15] [Client thread/INFO]: Setting user: Trudged
[12:05:19] [Client thread/INFO]: LWJGL Version: 3.1.6 build 14
[12:05:19] [Client thread/INFO]: [STDERR]: [LWJGL] Failed to load a library. Possible solutions:
	a) Add the directory that contains the shared library to -Djava.library.path or -Dorg.lwjgl.librarypath.
	b) Add the JAR that contains the shared library to the classpath.
[12:05:19] [Client thread/INFO]: [STDERR]: [LWJGL] Enable debug mode with -Dorg.lwjgl.util.Debug=true for better diagnostics.
[12:05:19] [Client thread/INFO]: [STDERR]: [LWJGL] Enable the SharedLibraryLoader debug mode with -Dorg.lwjgl.util.DebugLoader=true for better diagnostics.
---- Minecraft Crash Report ----
// Hi. I'm Minecraft, and I'm a crashaholic.

Time: 10/19/18 12:05 PM
Description: Initializing game

java.lang.UnsatisfiedLinkError: Failed to locate library: lwjgl.dll
	at org.lwjgl.system.Library.loadSystem(Library.java:147)
	at org.lwjgl.system.Library.loadSystem(Library.java:67)
	at org.lwjgl.system.Library.<clinit>(Library.java:50)
	at org.lwjgl.system.MemoryUtil.<clinit>(MemoryUtil.java:61)
	at org.lwjgl.system.MemoryStack.<init>(MemoryStack.java:61)
	at org.lwjgl.system.MemoryStack.create(MemoryStack.java:82)
	at org.lwjgl.system.MemoryStack.create(MemoryStack.java:71)
	at java.lang.ThreadLocal$SuppliedThreadLocal.initialValue(Unknown Source)
	at java.lang.ThreadLocal.setInitialValue(Unknown Source)
	at java.lang.ThreadLocal.get(Unknown Source)
	at org.lwjgl.system.MemoryStack.stackGet(MemoryStack.java:628)
	at org.lwjgl.system.MemoryStack.stackPush(MemoryStack.java:637)
	at cgc.a(SourceFile:127)
	at cfs.an(SourceFile:557)
	at cfs.am(SourceFile:436)
	at cfs.a(SourceFile:380)
	at net.minecraft.client.main.Main.main(SourceFile:144)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Client thread
Stacktrace:
	at org.lwjgl.system.Library.loadSystem(Library.java:147)
	at org.lwjgl.system.Library.loadSystem(Library.java:67)
	at org.lwjgl.system.Library.<clinit>(Library.java:50)
	at org.lwjgl.system.MemoryUtil.<clinit>(MemoryUtil.java:61)
	at org.lwjgl.system.MemoryStack.<init>(MemoryStack.java:61)
	at org.lwjgl.system.MemoryStack.create(MemoryStack.java:82)
	at org.lwjgl.system.MemoryStack.create(MemoryStack.java:71)
	at java.lang.ThreadLocal$SuppliedThreadLocal.initialValue(Unknown Source)
	at java.lang.ThreadLocal.setInitialValue(Unknown Source)
	at java.lang.ThreadLocal.get(Unknown Source)
	at org.lwjgl.system.MemoryStack.stackGet(MemoryStack.java:628)
	at org.lwjgl.system.MemoryStack.stackPush(MemoryStack.java:637)
	at cgc.a(SourceFile:127)
	at cfs.an(SourceFile:557)
	at cfs.am(SourceFile:436)

-- Initialization --
Details:
Stacktrace:
	at cfs.a(SourceFile:380)
	at net.minecraft.client.main.Main.main(SourceFile:144)

-- System Details --
Details:
	Minecraft Version: 1.13.1
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_131, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 813429232 bytes (775 MB) / 1038876672 bytes (990 MB) up to 2112618496 bytes (2014 MB)
	JVM Flags: 6 total; -XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms1024M -Xmx2048M -XX:MaxPermSize=256M
	Launched Version: 1.13.1
	LWJGL: 3.1.6 build 14
	OpenGL: ~~ERROR~~ NoClassDefFoundError: Could not initialize class org.lwjgl.system.Library
	GL Caps: 
	Using VBOs: Yes
	Is Modded: Probably not. Jar signature remains and client brand is untouched.
	Type: Client (map_client.txt)
	Resource Packs: 
	Current Language: ~~ERROR~~ NullPointerException: null
	Profiler Position: N/A (disabled)
	CPU: <unknown>
#@!@# Game crashed! Crash report saved to: #@!@# C:\Users\XX\AppData\Roaming\XX\instances\Vanilla 1.13 Package\minecraft\crash-reports\crash-2018-10-19_12.05.19-client.txt
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Process ended with code: -1```

Do you know how to fix this? It just ignored the flag.

@dogboy21
Copy link

The native library path was already needed before, so it's already in the command line arguments.

builder.getFlags().add("-Djava.library.path=" + extractDir.getAbsoluteFile());

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

Hm.. I'll take a look.

@EazyFTW
Copy link

EazyFTW commented Oct 19, 2018

It is there for me, but it still errors for some reason.

@samm2804
Copy link

samm2804 commented Feb 9, 2020

Hi there, I've downloaded forge and went onto the minecraft launcher selected forge for the profile and it says Failed to download file.
Name: jline-2.13.jar
Filename on disk: jline-2.13.jar
Exists: Nonexistent

Could someone please help me with this. i rlly need to fix this

@spannerman79
Copy link

@samm2804 read #235 (comment)

@josh6259
Copy link

So just wondering if anyone has made any progress on this? we've tried all the listed fixes, but still cannot compile any new modpacks, it's a very sad thing

@MBarnulf
Copy link

MBarnulf commented Jun 2, 2020

same as @josh6259 , looking to know if there was any fix that actually work... it will be 2 years now

@spannerman79
Copy link

@josh6259 @MajorBarnulf all you need to do is scroll up a little and view the comment I made back on the 9th Feb.

You actually need to do some work yourself until @sk89q fixes up this repo.

@mptorz
Copy link

mptorz commented Jun 11, 2020

I tried literally all the fixes and I tried modyfing the game myself. No success whatsoever :C (for MC 1.12.2 and forge)

@spannerman79
Copy link

The comment that I directed you does actually work. Like I stated you need to actually modify your own fork. Saying "I literally tied all the fixes" means you actually haven't when more then just one or two people here have indeed done that and have no issue with forge with 1.12 (and lower) custom packs.

Personally I do not care about 1.13 and above and neither do my player base when it comes to modded mc.

@johnfriedrich
Copy link
Contributor

Can also confirm it works. Using a similiar/same way for two years or so

@josh6259
Copy link

josh6259 commented Jun 11, 2020 via email

@johnfriedrich
Copy link
Contributor

1.13+ only works for vanilla with that fix, but not for Forge. But thats anither bugticket

@josh6259
Copy link

josh6259 commented Jun 11, 2020 via email

@mptorz
Copy link

mptorz commented Jun 16, 2020

@spannerman79 I am not sure what I am doing wrong then.

I downloaded @Routhinator 's fork and created a very simple modpack using minecraft 1.12.2 and forge. Unfortunately I always get this errors:

To report this error, please provide:

java.io.IOException: 3 file(s) could not be downloaded
	at com.skcraft.launcher.install.HttpDownloader.execute(HttpDownloader.java:139)
	at com.skcraft.launcher.install.Installer.download(Installer.java:46)
	at com.skcraft.launcher.update.Updater.update(Updater.java:175)
	at com.skcraft.launcher.update.Updater.call(Updater.java:95)
	at com.skcraft.launcher.update.Updater.call(Updater.java:38)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

I also tried applying other fixes I found in the thread separately and using diffrent forge versions. Sadly, no success. What did other people try, that I missed?

@mptorz
Copy link

mptorz commented Jun 16, 2020

@spannerman79 When did you last check whether it works? Even if I just download routinator fork and don't make any changes there, but just build and run (leave his modpacks there). I cannot start minecraft through the launcher.

@mptorz
Copy link

mptorz commented Jun 16, 2020

Can also confirm it works. Using a similiar/same way for two years or so

Hey @i9hdkill would you be able to share your fork?

@Routhinator
Copy link

Our most recent fork is here, and it supports all the way up to 1.14:
https://gitlab.routh.io/minecraft/launchers/routh-io-skcraft

Be forewarned though - I haven't announced this or put an MR back here yet as there are major changes....

  • build tools dropped
  • launcher variants merged to 1 launcher
  • code refactoring and removal of unused code
  • implementation of JavaFX for html 5 support

Building packs for this fork of the launcher is done with the new tool Packmaker: https://gitlab.routh.io/minecraft/tools/packmaker

@mptorz
Copy link

mptorz commented Jun 16, 2020

@Routhinator Unfortunately, I am not able to build that or previous releases at all. I opened an issue at your repo https://gitlab.routh.io/minecraft/launchers/routh-io-skcraft/-/issues/20

@budgej
Copy link

budgej commented Jun 16, 2020

Is there any plan to release a Windows-compatible version of the pack maker?

@spannerman79
Copy link

@budgej if your discussing another fork take the discussion over to that git repo. Not here. This issue tracker is to do with specific this repo.

Here is a starter

@i-eat-burgers
Copy link

If any of you need help making this work for MC 1.13+ hit me up <3

@hedgehog1029
Copy link
Member

This is now fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests