-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add or create labels during upload #4901
Open
perryr16
wants to merge
8
commits into
develop
Choose a base branch
from
4789-import-labels
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
added
the
Feature
Add this label to new features. This will be reflected in the change log when generated.
label
Dec 12, 2024
perryr16
force-pushed
the
4789-import-labels
branch
from
December 17, 2024 19:00
2ffbbc8
to
6edc3a1
Compare
kflemin
approved these changes
Jan 27, 2025
kflemin
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perryr16 This is almost working!
- I've noticed that nothing happens with the labels if we are importing data into a cycle that already has data in it (performing a merge). No new labels are created, and the property labels are not added to the properties. Doesn't matter if the existing property had a label already or didn't. It does work as designed in an empty cycle though.
- When creating a new label via import (and really any time), can you make the default be "show in list = true" instead of false? It's confusing otherwise.
- Can you also remove the first line of the csv inventory export that lists some information about filters? It breaks the subsequent CSV import and is not comprehensive anyway. I think just listing the headers directly will be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Add this label to new features. This will be reflected in the change log when generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
What's this PR do?
Allows users to upload property and taxlot labels. Incoming values in a csv's "Property Labels" or "Tax Lot Labels" column will be processed and applied as a label. If a label does not exist, one will be created.
Labels are applied to a
PropertyView
, however during the upload processPropertyStates
are created (mapping) several steps before aPropertyView
is applied (matching). As a result, thePropertyState
has to carry the incoming label information in a new text fieldPropertyState.incoming_labels
until it can be applied to the relatedPropertyView
.How should this be manually tested?
From the inventory list, export a set of properties to a csv or spreadsheet. Then in a new cycle, upload that exported file, confirm the correct labels are applied.
What are the relevant tickets?
#4789
Screenshots (if appropriate)