scst_vdisk: Fix recent breakage in vdisk_exec_read_capacity16 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit (974001f) added backport support for bdev_open_by_path. This entailed adding a struct bdev_handle, but vdisk_exec_read_capacity16 attempts to lookup virt_dev->bdev_handle->bdev without regard for the fact that if we are not using blockio then bdev_handle will be null. Rectify by making the lookup more robust.
bmeagherix
force-pushed
the
fix_vdisk_exec_read_capacity16
branch
from
c8e9d5e to
4605882
Compare
|
Hi Brian, Thank you for the patch! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit (974001f) added backport support for
bdev_open_by_path. This entailed adding astruct bdev_handle, but invdisk_exec_read_capacity16the code attempts to lookupvirt_dev->bdev_handle->bdevwithout regard for the fact that if we are not using blockio thenbdev_handlewill be null. Rectify by making the lookup more robust.