support getting and setting the positions of material points #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortran/c interface passes isMPActive
using kkVec3dViewHostU causes the array order to be incorrect... not clear why
onkarsahni
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good. Some changes needed (including _f for fortran bindings as updated in PR #22).
Co-authored-by: onkarsahni <[email protected]>
Co-authored-by: onkarsahni <[email protected]>
Co-authored-by: onkarsahni <[email protected]>
Co-authored-by: onkarsahni <[email protected]>
Co-authored-by: onkarsahni <[email protected]>
Conflicts: src/pmpo_c.cpp src/pmpo_c.h
onkarsahni
requested changes
Oct 20, 2023
onkarsahni
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Line 98: isMPActive = MP_ACTIVE !no inactive MPs and some changed below
There was a problem hiding this comment.
good catch, fixed fdc7119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
polympo_setMPPositionsand refactors thepolympo_getMPPositionsAPIs that support passing host arrays with material point positions to the GPU structures maintained by pumipic.All
ctests pass oncranium.Note, issue #21 applies to the code used in these APIs as 2d arrays are being passed between the host to device.