Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove capstone_clis #464

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Oct 30, 2024

Remove capstone_clis

Remove the capstone_clis folder because it violates the repository convention of libraries in subdirectories and executables in test. Utility executables were moved to test as util_exe_func targets. Unusable test cases (no input meshes, unclear usage) were removed.

  • Move capStoneGeomTest, capCheckParam, capStone2VTK to the test subdirectory as utility functions.
  • Remove exes which were based on capStoneAnisoAdapt (the wing specific version).
  • Remove exes which were not in CMakeLists.txt (old ad-hoc tests).
  • Move capStoneSizeFields.h to test/capVolSizeFields.h.
  • Removed capStoneAttachSolution which I could not find input files for.

- My rationale is that these are old ad-hoc tests.
- Removed B737 test as well. The CRE is not available so it should not
  be a test.

Signed-off-by: Aiden Woodruff <[email protected]>
- Moved capStoneCheckParameterization because it's a good utility to
  confirm the curved mesh is correct.
- Moved capStoneGeomTest because it can be used to examine a geometry.

Signed-off-by: Aiden Woodruff <[email protected]>
- It is a copy of capStoneAnisoAdapt with a specific shock field.

Signed-off-by: Aiden Woodruff <[email protected]>
- Remove capStoneAnisoAdapt which became capVol.
- Move capStoneSizeFields.h to test/capVolSizeFields.h.
- Update `#include` and CMake include_directories.

Signed-off-by: Aiden Woodruff <[email protected]>
- Remove capstone_clis CMake file.
- Remove capStoneAttachSolution.cc. I thought robin-data would be the
  input but couldn't figure out how to use this test.

Signed-off-by: Aiden Woodruff <[email protected]>
@bobpaw bobpaw requested a review from cwsmith October 30, 2024 00:55
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cwsmith cwsmith merged commit 7c9ffe5 into SCOREC:develop Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants