-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Number of Tags #548
Limit Number of Tags #548
Conversation
Need more opinions before we limit the characters to a certain length, 3 might be too short. Things like "casual" or "strategy" are longer but probably would be commonly used. I do think we should set an overall limit though, not sure if this has been done in the API yet. We don't want 50 character length tags. I think the best options is to either limit the number of tags to 3/4, or expand the card width. @jbytes1027 @evan-scales @AaronKeys what do you think? |
I think 4 tags =<10 characters each would work find and would probably fit. |
I think the 10-character limit is a good idea. Having 4 tags seems like a strange number to have. I think it should be 3 or 5, but if y'all want 4, that's fine with me. |
Sounds good to me, |
…rrors. Create Post button is disabled if there are errorrs.
I set the character limit to 10 and the overall limit to 4. I also added the error helpertexts. tag.limit.mp4 |
looks really good, ill test it in a couple of minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This only allows 6 tags to be selected, @epadams suggested we do 3 character tags only, which i think is fine. Alternatively we could keep the amount of characters the same as we have it now, but limit the amount to tags to 3.