Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local screenshots #539

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Use local screenshots #539

merged 1 commit into from
Apr 18, 2024

Conversation

jbytes1027
Copy link
Contributor

Switches screenshots from cloud to local storage. Mainly done so that it doesn't depend on Evans blob storage so I can host it myself later if I want. The loading error should be fixed. I tested the built version.

This reverts commit c6a6e4e.
@jbytes1027 jbytes1027 requested a review from evan-scales April 18, 2024 02:58
Copy link
Collaborator

@evan-scales evan-scales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this approach will work on the deployed site by doing the same thing on our azure class project and redeploying. Do you think we should redeploy these changes today too? Or maybe it would be better to save joses action minutes
image

@evan-scales evan-scales marked this pull request as draft April 18, 2024 18:57
@evan-scales evan-scales marked this pull request as ready for review April 18, 2024 18:57
@evan-scales evan-scales merged commit 0943cbf into main Apr 18, 2024
2 checks passed
@evan-scales evan-scales deleted the FixImages branch April 18, 2024 19:00
@jbytes1027
Copy link
Contributor Author

I'm fine with waiting, I don't think it's worth it to redeploy for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants