Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Page to 1 when theres new search text #520

Merged
merged 4 commits into from
Apr 14, 2024
Merged

Set Page to 1 when theres new search text #520

merged 4 commits into from
Apr 14, 2024

Conversation

Jackson-Williams-15
Copy link
Contributor

Sets page to 1 when the search text is updated
image
image

@Jackson-Williams-15 Jackson-Williams-15 linked an issue Apr 14, 2024 that may be closed by this pull request
Searching for a User on a further page than the amount of users that have a similar name will return the nothing #493
Closed
evan-scales
evan-scales requested changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@evan-scales evan-scales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do the same for social too

@Jackson-Williams-15
Copy link
Contributor Author

I think we should do the same for social too

updated with 72545cc

@Jackson-Williams-15 Jackson-Williams-15 marked this pull request as draft April 14, 2024 21:06
@Jackson-Williams-15 Jackson-Williams-15 marked this pull request as ready for review April 14, 2024 21:06
@Jackson-Williams-15 Jackson-Williams-15 merged commit 96f5a90 into main Apr 14, 2024
2 checks passed
@Jackson-Williams-15 Jackson-Williams-15 mentioned this pull request Apr 14, 2024
Closed
@evan-scales evan-scales deleted the 493 branch April 15, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-scales evan-scales evan-scales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Jackson-Williams-15 @evan-scales