Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

491: Restrict passwords #506

Merged
merged 3 commits into from
Apr 14, 2024
Merged

491: Restrict passwords #506

merged 3 commits into from
Apr 14, 2024

Conversation

evan-scales
Copy link
Collaborator

@evan-scales evan-scales commented Apr 11, 2024 •
edited
Loading

  • Passwords now must be at least 5 chracters long, and have either a special character or number
  • Removed confirm password

@evan-scales evan-scales linked an issue Apr 11, 2024 that may be closed by this pull request
User can create a password with one character or as many characters as possible #491
Closed
Jackson-Williams-15
Jackson-Williams-15 reviewed Apr 13, 2024
View reviewed changes
Copy link
Contributor

@Jackson-Williams-15 Jackson-Williams-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, but do you think we should do at least 8 characters instead of 5? I feel like most other sites do that.

@evan-scales
Copy link
Collaborator Author

@Jackson-Williams-15 Makes sense. Updated with ff35d87

Jackson-Williams-15
Jackson-Williams-15 previously approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@Jackson-Williams-15 Jackson-Williams-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Jackson-Williams-15 Jackson-Williams-15 marked this pull request as draft April 14, 2024 20:15
@Jackson-Williams-15 Jackson-Williams-15 marked this pull request as ready for review April 14, 2024 20:15
Jackson-Williams-15
Jackson-Williams-15 reviewed Apr 14, 2024
View reviewed changes
Copy link
Contributor

@Jackson-Williams-15 Jackson-Williams-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-scales the check for the api failed

@evan-scales evan-scales marked this pull request as draft April 14, 2024 21:04
@evan-scales evan-scales marked this pull request as ready for review April 14, 2024 21:04
Jackson-Williams-15
Jackson-Williams-15 approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@Jackson-Williams-15 Jackson-Williams-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@evan-scales evan-scales merged commit 4a9bdb6 into main Apr 14, 2024
2 checks passed
@evan-scales evan-scales deleted the 491 branch April 14, 2024 21:11
@Jackson-Williams-15 Jackson-Williams-15 mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackson-Williams-15 Jackson-Williams-15 Jackson-Williams-15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User can create a password with one character or as many characters as possible
2 participants
@evan-scales @Jackson-Williams-15