Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert relevant alerts to react notifications #484

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Convert relevant alerts to react notifications #484

merged 7 commits into from
Apr 15, 2024

Conversation

epadams
Copy link
Contributor

@epadams epadams commented Apr 7, 2024 •
edited
Loading

  • Converts alerts to react-notifications
    • The AccountSettings alerts could be converted to check state and display errors in the TextField like with SignIn and Create, let me know if that is something that should be done
  • Tried making a comment on the code but it wouldn't let me, line 77-81 might want to be replaced by a <Dialog />

@epadams epadams self-assigned this Apr 7, 2024
@epadams epadams linked an issue Apr 7, 2024 that may be closed by this pull request
Replace window alerts with React Notifications #469
Closed
@epadams epadams marked this pull request as draft April 7, 2024 23:52
@epadams epadams mentioned this pull request Apr 8, 2024
Closed
@epadams epadams requested a review from evan-scales April 14, 2024 16:56
@epadams epadams marked this pull request as ready for review April 14, 2024 16:56
@epadams epadams marked this pull request as draft April 14, 2024 16:57
@epadams epadams marked this pull request as ready for review April 14, 2024 16:57
@epadams epadams mentioned this pull request Apr 14, 2024
Closed
evan-scales
evan-scales approved these changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@evan-scales evan-scales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@evan-scales evan-scales marked this pull request as draft April 14, 2024 21:10
@evan-scales evan-scales marked this pull request as ready for review April 14, 2024 21:10
@epadams epadams merged commit afa4313 into main Apr 15, 2024
2 checks passed
@epadams epadams deleted the 469 branch April 15, 2024 01:34
@epadams epadams mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-scales evan-scales evan-scales approved these changes

Assignees

@epadams epadams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace window alerts with React Notifications
2 participants
@epadams @evan-scales