Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-menu): fix focus steal of ui5-wizard in mozilla #9845

Merged
merged 15 commits into from
Oct 9, 2024

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Sep 11, 2024

Previously in Mozilla Firefox browser the ui5-menu was 'stealing' the focus of the ui5-wizard resulting in scroll back through the steps.
The problem occured when the ui5-wizard contained a menu, with or without ui5-menu-item, and sub-menus. The reason was due to some timing issue, when executing the _createSubMenu() --then--> _openItemSubMenu() methods in the ui5-menu.

Before

2024-09-11_14-09-24

After

2024-09-11_14-16-35

Fixes: #8544

hinzzx and others added 9 commits May 13, 2024 10:33
…secondary calendar type (#8453)

Now, when any of the two calendar types (Persian or Islamic) is set as a secondaryCalendarType, when the end user is in month view of the calendar, the months are displayed in two column layout, instead of three, providing enough space for the texts to be displayed in one row.
…lation (#8971)

Fixed edge case where when a calendarType was being set to Islamic or Buddhist in the document configuration, and a primary-calendar-type="Gregorian" on a date component level where week numbering is present, the week numbers were calculated wrong.
@hinzzx hinzzx changed the base branch from main to release-1.24 September 11, 2024 11:19
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
Copy link
Member

@Todor-ads Todor-ads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the change already looks good. Can Tsanislav take a look as well?

@hinzzx hinzzx marked this pull request as ready for review October 9, 2024 06:09
@hinzzx hinzzx requested a review from tsanislavgatev October 9, 2024 06:09
@hinzzx hinzzx merged commit c0c90b2 into release-1.24 Oct 9, 2024
9 checks passed
@hinzzx hinzzx deleted the menu-foc-steal-1.24 branch October 9, 2024 07:02
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Oct 29, 2024

🎉 This PR is included in version v1.24.12 🎉

The release is available on v1.24.12

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][Wizard]: Wizard will scroll back to step 1 when open Menu popover(Firefox 124.0.1)
4 participants