-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-menu): fix focus steal of ui5-wizard in mozilla #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…secondary calendar type (#8453) Now, when any of the two calendar types (Persian or Islamic) is set as a secondaryCalendarType, when the end user is in month view of the calendar, the months are displayed in two column layout, instead of three, providing enough space for the texts to be displayed in one row.
… into release-1.24
…lation (#8971) Fixed edge case where when a calendarType was being set to Islamic or Buddhist in the document configuration, and a primary-calendar-type="Gregorian" on a date component level where week numbering is present, the week numbers were calculated wrong.
… into release-1.24
… into release-1.24
… into release-1.24
… into release-1.24
… into release-1.24
Todor-ads
requested changes
Sep 25, 2024
Todor-ads
approved these changes
Oct 1, 2024
Todor-ads
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the change already looks good. Can Tsanislav take a look as well?
… into release-1.24
tsanislavgatev
approved these changes
Oct 9, 2024
Closed
1 task
🎉 This PR is included in version v1.24.12 🎉 The release is available on v1.24.12 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in Mozilla Firefox browser the
ui5-menu
was 'stealing' the focus of theui5-wizard
resulting in scroll back through the steps.The problem occured when the
ui5-wizard
contained a menu, with or withoutui5-menu-item
, and sub-menus. The reason was due to some timing issue, when executing the_createSubMenu()
--then-->_openItemSubMenu()
methods in theui5-menu
.Before
After
Fixes: #8544