Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-file-uploader): rename file size exceed event #9780

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

tsanislavgatev
Copy link
Contributor

@tsanislavgatev tsanislavgatev commented Aug 30, 2024

We are renaming the fileSizeExceeded event to file-size-exceed so it's consistent with the framework convention.

If you were using it as:

fileUploader.addEventListener("fileSizeExceeded", function (event) {
       alert("File is too big!");
}

You should now use it as:

fileUploader.addEventListener("file-size-exceed", function (event) {
       alert("File is too big!");
}

@ilhan007 ilhan007 marked this pull request as ready for review September 3, 2024 06:08
@tsanislavgatev tsanislavgatev merged commit 29b88e7 into main Sep 3, 2024
10 checks passed
@tsanislavgatev tsanislavgatev deleted the file-uploader-event-rename branch September 3, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants