chore(ui5-breadcrumbs): current location hybrid #9421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
4 times, most recently
from
0e0c339 to
9b70d51
Compare
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
from
9b70d51 to
aabf59f
Compare
kineticjs
reviewed
Jul 17, 2024
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
from
aabf59f to
2979d2d
Compare
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
from
2979d2d to
a3a305d
Compare
kineticjs
approved these changes
Jul 18, 2024
|
Related to: #8853 |
|
Removing the href of the last item during runtime has no effect on the last item. Rerendering is triggered, though. |
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
from
a3a305d to
163632a
Compare
done, I was wrongly checking for indifference with only undefined falsy value, when the href resulted in a null one. |
dobrinyonkov
approved these changes
Aug 7, 2024
PetyaMarkovaBogdanova
force-pushed
the
breadcrumbs-current-loc-text-link
branch
from
163632a to
fe86283
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding to recent feedback we move back the variant with breadcrumbs current item implemented as a text and kept the functionality to visualise it as a link if a href is passed to the last breadcrumbs item.