feat(ui5-user-menu): introduce show-edit-button property
#10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobromiraboycheva
force-pushed
the
user-menu-edit-avar-button
branch
from
055df9f to
ee6c722
Compare
ilhan007
reviewed
Jan 22, 2025
packages/fiori/src/UserMenu.ts
Outdated
| * @since 2.7.0 | ||
| */ | ||
| @property({ type: Boolean }) | ||
| hideEditAvatar = false; |
There was a problem hiding this comment.
Is it only applicable for the UserMenuAccount or it's more than that, because we can discuss if it belongs here or to the UserMenuAccount
There was a problem hiding this comment.
it is applied to the avatar in the user menu but in one UserMenu you can have more than one account, on the other hand, if it is set on UserMenuAccount it should be set from the application to each account that is added.
I did it this way because for example FLP is used for all accounts and as I understood it would be on the area level as functionality not by the user
dobromiraboycheva
changed the title
hide-edit-avatar propertyshow-edit-button property
…user-menu-edit-avar-button
vladitasev
approved these changes
Jan 27, 2025
|
🎉 This PR is included in version v2.7.0-rc.2 🎉 The release is available on v2.7.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10599
Introducing
show-edit-buttonproperty into the<ui5-user-menu>web component.The
show-edit-buttonproperty allows you to show the icon for editing on top of avatar.The default value of
show-edit-buttonproperty isfalse.