chore(ui5-select): migrate to tsx template #10469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Jan 7, 2025
| horizontalAlign="Start" | ||
| hideArrow={true} | ||
| preventInitialFocus={true} | ||
| onui5-open={this._afterOpen} |
There was a problem hiding this comment.
onOpen, onBeforeOpen, onClose should be available on ResponsivePopover
ilhan007
reviewed
Jan 7, 2025
| selectionMode="SingleAuto" | ||
| separators="None" | ||
| onMouseDown={this._itemMousedown} | ||
| onui5-item-click={this._handleItemPress} |
There was a problem hiding this comment.
Here you should use onItemClick.
We only need to use "onui5-" on elements that don't emit the expected event, for example if we want to listen on a "div", wrapping a List, then we must use "onui5-item-click", because the "div" does not have such an event.
Whenever we listen on web component level, we can use the camelCase event name that is also suggested and autocompleted.
There was a problem hiding this comment.
Thank you for the clarification! This makes perfect sense now. I appreciate the detailed explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10046