Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-flexible-column-layout): add arrow icon functionality #10362

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(ui5-flexible-column-layout): add arrow icon functionality #10362

wants to merge 6 commits into from

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Dec 11, 2024 •
edited
Loading

  • Added the icon in the FCL tsx template(positioned in the first separator)
  • Added basic styling for the icon
  • Added functionality for the icon, so we can toggle the first column toggleStartColumnVisibility
  • Added arrowIconName to conditionally display navigation-right-arrow or navigation-left-arrow based on the layout
  • Added two new layouts ThreeColumnsBeginHiddenMidExpanded and ThreeColumnsBeginHiddenEndExpanded
  • Added a new variable to check if the FCL is or was set to the new layouts _hasBeenInIconVisibleLayout so we can have the icon to specific layouts
  • Added keyboard handling for the icon (When Enter or Space is pressed on the icon, the icon is toggled)
  • Added keyboard handling for the icon (when the focus is on the arrow and we press left or right key)
  • Added new sample in the test page
  • Added tests

JIRA: BGSOFUIPIRIN-6623

@NakataCode NakataCode requested a review from kineticjs December 11, 2024 14:01
@NakataCode NakataCode marked this pull request as ready for review December 16, 2024 10:21
kineticjs
kineticjs requested changes Jan 7, 2025
View reviewed changes
packages/fiori/src/FlexibleColumnLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/FlexibleColumnLayoutTemplate.tsx Outdated Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/themes/FlexibleColumnLayout.css Show resolved Hide resolved
packages/fiori/src/FlexibleColumnLayout.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kineticjs kineticjs kineticjs requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NakataCode @kineticjs