Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-radio-button): fix aria-disabled and focus of the read-only radio buttons #10111

Merged
merged 11 commits into from
Nov 26, 2024
Merged

fix(ui5-radio-button): fix aria-disabled and focus of the read-only radio buttons #10111

merged 11 commits into from
Nov 26, 2024

Conversation

LidiyaGeorgieva
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva commented Oct 30, 2024 •
edited
Loading

This pull request fixes two issues, related with the read-only radio buttons:

  1. radio buttons can not be focused using the keyboard
  2. radio buttons lack the aria-disabled attribute and the screen reader doesn't announce that they
    can't be selected

fixes: #10025

@LidiyaGeorgieva
fix(ui5-radio-button): fix aria-disabled and focus of the read-only r…
ce04924 
…adio buttons

This pull request fixes two issues:
1. radio buttons cannot be focused using the keyboard
2. radio buttons lack the aria-disabled attribute
and the screen reader doesn't announce that they
can't be selected

fixes: #10025
dimovpetar
dimovpetar requested changes Nov 1, 2024
View reviewed changes
packages/main/src/RadioButtonGroup.ts Outdated Show resolved Hide resolved
packages/main/src/RadioButtonGroup.ts Show resolved Hide resolved
dimovpetar

This comment was marked as resolved.

Sign in to view

TeodorTaushanov

This comment was marked as outdated.

Sign in to view

BorisDafov
BorisDafov suggested changes Nov 18, 2024
View reviewed changes
packages/main/src/RadioButton.ts Outdated Show resolved Hide resolved
packages/main/src/RadioButton.ts Outdated Show resolved Hide resolved
@LidiyaGeorgieva LidiyaGeorgieva requested a review from a team November 25, 2024 11:03
@LidiyaGeorgieva
Copy link
Contributor Author

When a readonly element is focused and "tab" key is pressed, the focus goes to the next element inside the group, but it should leave the group.

Done

@LidiyaGeorgieva
Copy link
Contributor Author

Now you can have more than 1 button selected in a group. To reproduce it:

  1. Open http://localhost:8080/packages/main/test/pages/RadioButton.html
  2. Go to "Group 3"
  3. Press arrow down multiple times, until you get such state:
    {3981E003-1456-45F1-923F-B39F2A33D89E}

Done

@LidiyaGeorgieva LidiyaGeorgieva merged commit 3bcfd1d into main Nov 26, 2024
10 checks passed
@LidiyaGeorgieva LidiyaGeorgieva deleted the ui5-radio-button-ACC branch November 26, 2024 09:43
LidiyaGeorgieva added a commit that referenced this pull request Nov 26, 2024
@LidiyaGeorgieva
fix(ui5-radio-button): fix aria-disabled and focus of the read-only r…
e8a4db3 
…adio buttons

This pull request fixes two issues:
1. radio buttons cannot be focused using the keyboard
2. radio buttons lack the aria-disabled attribute
and the screen reader doesn't announce that they
can't be selected

fixes: #10025
downport of: #10111
@LidiyaGeorgieva LidiyaGeorgieva mentioned this pull request Nov 26, 2024
Merged
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.2 🎉

The release is available on v2.5.0-rc.2

Your semantic-release bot 📦🚀

LidiyaGeorgieva added a commit that referenced this pull request Nov 29, 2024
@LidiyaGeorgieva
fix(ui5-radio-button): fix aria-disabled and focus of the read-only r…
be55dc1 
…adio buttons (#10257)

This pull request fixes two issues:
1. radio buttons cannot be focused using the keyboard
2. radio buttons lack the aria-disabled attribute
and the screen reader doesn't announce that they
can't be selected

fixes: #10025
downport of: #10111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisDafov BorisDafov BorisDafov approved these changes

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

@GerganaKremenska GerganaKremenska Awaiting requested review from GerganaKremenska

@dimovpetar dimovpetar Awaiting requested review from dimovpetar

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Radio Button]: Read only state not announced by screen readers
5 participants
@LidiyaGeorgieva @ui5-webcomponents-bot @TeodorTaushanov @dimovpetar @BorisDafov