Skip to content

Commit

Permalink
fix(ui5-table): fix border and focus overlap (#9752)
Browse files Browse the repository at this point in the history
Fixes: #9526
  • Loading branch information
nnaydenow authored Aug 28, 2024
1 parent 2165e76 commit f7085b5
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion packages/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"devDependencies": {
"@openui5/sap.ui.core": "1.120.17",
"@ui5/webcomponents-tools": "1.24.8",
"chromedriver": "^126.0.2",
"chromedriver": "^127.0.3",
"clean-css": "^5.2.2",
"copy-and-watch": "^0.1.5",
"cross-env": "^7.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.24.8",
"chromedriver": "^126.0.2"
"chromedriver": "^127.0.3"
}
}
2 changes: 1 addition & 1 deletion packages/localization/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@openui5/sap.ui.core": "1.120.17",
"@ui5/webcomponents-tools": "1.24.8",
"babel-plugin-amd-to-esm": "^2.0.3",
"chromedriver": "^126.0.2",
"chromedriver": "^127.0.3",
"estree-walk": "^2.2.0",
"mkdirp": "^1.0.4",
"resolve": "^1.20.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/main/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.24.8",
"chromedriver": "^126.0.2"
"chromedriver": "^127.0.3"
}
}
1 change: 1 addition & 0 deletions packages/main/src/themes/base/Table-parameters.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
:root {
--ui5_table_focus_outline_offset: -0.125rem;
--ui5_table_bottom_border: 1px solid var(--sapList_BorderColor);
--ui5_table_header_row_outline_width: 1px;
--ui5_table_multiselect_column_width: 2.75rem;
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/themes/base/sizes-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
--_ui5_load_more_desc_padding: 0.375rem 2rem 0.875rem 2rem;
--ui5_table_header_row_height: 2.75rem;
--ui5_table_row_height: 2.75rem;
--ui5_table_focus_outline_offset: -0.125rem;
--ui5_table_group_row_height: 2rem;

/* Tree */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
--ui5_table_header_row_outline_width: 0.125rem;
--ui5_table_header_row_font_family: var(--sapFontSemiboldDuplexFamily);
--ui5_table_header_row_border_bottom_color: var(--sapList_HeaderBorderColor);
--ui5_table_focus_outline_offset: -0.1875rem;
--ui5_table_focus_outline_offset: -0.25rem;
--ui5_table_header_row_border_width: 0.1875rem;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
--ui5_table_header_row_outline_width: 0.125rem;
--ui5_table_header_row_font_family: var(--sapFontSemiboldDuplexFamily);
--ui5_table_header_row_border_bottom_color: var(--sapList_HeaderBorderColor);
--ui5_table_focus_outline_offset: -0.1875rem;
--ui5_table_focus_outline_offset: -0.25rem;
--ui5_table_header_row_border_width: 0.1875rem;
}
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6688,10 +6688,10 @@ axios@^1.0.0:
form-data "^4.0.0"
proxy-from-env "^1.1.0"

axios@^1.6.7:
version "1.6.8"
resolved "https://registry.yarnpkg.com/axios/-/axios-1.6.8.tgz#66d294951f5d988a00e87a0ffb955316a619ea66"
integrity sha512-v/ZHtJDU39mDpyBoFVkETcd/uNdxrWRrg3bKpOKzXFA6Bvqopts6ALSMU3y6ijYxbw2B+wPrIv46egTzJXCLGQ==
axios@^1.7.4:
version "1.7.5"
resolved "https://registry.yarnpkg.com/axios/-/axios-1.7.5.tgz#21eed340eb5daf47d29b6e002424b3e88c8c54b1"
integrity sha512-fZu86yCo+svH3uqJ/yTdQ0QHpQu5oL+/QE+QPSv6BZSkDAoky9vytxp7u5qk83OJFS3kEBcesWni9WTZAv3tSw==
dependencies:
follow-redirects "^1.15.6"
form-data "^4.0.0"
Expand Down Expand Up @@ -7520,13 +7520,13 @@ chrome-trace-event@^1.0.2:
resolved "https://registry.yarnpkg.com/chrome-trace-event/-/chrome-trace-event-1.0.3.tgz#1015eced4741e15d06664a957dbbf50d041e26ac"
integrity sha512-p3KULyQg4S7NIHixdwbGX+nFHkoBiA4YQmyWtjb8XngSKV124nJmRysgAeujbUVb15vh+RvFUfCPqU7rXk+hZg==

chromedriver@^126.0.2:
version "126.0.2"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-126.0.2.tgz#0c0840cd1ba00b73fa16d4292fa739860ee20ec8"
integrity sha512-61R0w7C+uJVCykabdqWsvitne2rg3MTI8xOKJosk+YbKdyLeGHYiCCeU82ZsUY+v9qnN1p48THcthgKubxPRWQ==
chromedriver@^127.0.3:
version "127.0.3"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-127.0.3.tgz#33abca5924eb809e0e6ef2dd30eaa8cf7dba58d4"
integrity sha512-trUHkFt0n7jGzNOgkO1srOJfz50kKyAGJ016PyV0hrtyKNIGnOC9r3Jlssz19UoEjSzI/1g2shEiIFtDbBYVaw==
dependencies:
"@testim/chrome-version" "^1.1.4"
axios "^1.6.7"
axios "^1.7.4"
compare-versions "^6.1.0"
extract-zip "^2.0.1"
proxy-agent "^6.4.0"
Expand Down

0 comments on commit f7085b5

Please sign in to comment.