fix: i18n decorator property definition

SAP · Jan 10, 2025 · af6ae6b · af6ae6b
1 parent b79b529
commit af6ae6b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/base/src/UI5Element.ts b/packages/base/src/UI5Element.ts
@@ -41,6 +41,7 @@ import { updateFormValue, setFormValue } from "./features/InputElementsFormSuppo
 import type { IFormInputElement } from "./features/InputElementsFormSupport.js";
 import { getComponentFeature, subscribeForFeatureLoad } from "./FeaturesRegistry.js";
 import { getI18nBundle } from "./i18nBundle.js";
+import type I18nBundle from "./i18nBundle.js";
 import { fetchCldr } from "./asset-registries/LocaleData.js";
 import getLocale from "./locale/getLocale.js";
 
@@ -1288,6 +1289,11 @@ abstract class UI5Element extends HTMLElement {
 
 	static asyncFinished: boolean;
 	static definePromise: Promise<void> | undefined;
+	static i18nBundleStorage: Record<string, I18nBundle> = {};
+
+	static get i18nBundles(): Record<string, I18nBundle> {
+		return this.i18nBundleStorage;
+	}
 
 	/**
 	 * Registers a UI5 Web Component in the browser window object
@@ -1304,8 +1310,7 @@ abstract class UI5Element extends HTMLElement {
 			const [i18nBundles] = result;
 			Object.entries(this.getMetadata().getI18n()).forEach((pair, index) => {
 				const propertyName = pair[0];
-				const targetClass = pair[1].target;
-				(targetClass as Record<string, any>)[propertyName] = i18nBundles[index];
+				this.i18nBundleStorage[propertyName] = i18nBundles[index];
 			});
 			this.asyncFinished = true;
 		};

diff --git a/packages/base/src/decorators/i18n.ts b/packages/base/src/decorators/i18n.ts
@@ -20,6 +20,13 @@ const i18n = (bundleName: string): i18nDecorator => {
 		if (!target.metadata.i18n) {
 			target.metadata.i18n = {};
 		}
+
+		Object.defineProperty(target, propertyName, {
+			get() {
+				return target.i18nBundles[propertyName];
+			},
+		});
+
 		target.metadata.i18n[propertyName] = {
 			bundleName,
 			target,