fix(framework): getComponentFeature can return undefined (#10456)

SAP · Jan 3, 2025 · 7da765c · 7da765c
1 parent ef59e50
commit 7da765c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/base/src/FeaturesRegistry.ts b/packages/base/src/FeaturesRegistry.ts
@@ -37,7 +37,7 @@ const registerComponentFeature = async (name: string, feature: typeof ComponentF
 	notifyForFeatureLoad(name);
 };
 
-const getComponentFeature = <T>(name: string): T => {
+const getComponentFeature = <T>(name: string): T | undefined => {
 	return componentFeatures.get(name) as T;
 };
 

diff --git a/packages/main/src/ColorPalette.ts b/packages/main/src/ColorPalette.ts
@@ -207,8 +207,8 @@ class ColorPalette extends UI5Element {
 
 		if (this.showMoreColors) {
 			const ColorPaletteMoreColorsClass = getComponentFeature<typeof ColorPaletteMoreColors>("ColorPaletteMoreColors");
-			ColorPaletteMoreColorsClass.i18nBundle = ColorPalette.i18nBundle;
 			if (ColorPaletteMoreColorsClass) {
+				ColorPaletteMoreColorsClass.i18nBundle = ColorPalette.i18nBundle;
 				this.moreColorsFeature = new ColorPaletteMoreColorsClass();
 			}
 		}

diff --git a/packages/main/src/Input.ts b/packages/main/src/Input.ts
@@ -1263,8 +1263,8 @@ class Input extends UI5Element implements SuggestionComponent, IFormInputElement
 		}
 
 		const Suggestions = getComponentFeature<typeof InputSuggestions>("InputSuggestions");
-		Suggestions.i18nBundle = Input.i18nBundle;
 		if (Suggestions) {
+			Suggestions.i18nBundle = Input.i18nBundle;
 			this.Suggestions = new Suggestions(this, "suggestionItems", true, false);
 		}
 	}