chore: address code comments

SAP · Jan 6, 2025 · 70dde21 · 70dde21
1 parent 640f157
commit 70dde21
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/fiori/src/NavigationLayout.ts b/packages/fiori/src/NavigationLayout.ts
@@ -59,7 +59,7 @@ class NavigationLayout extends UI5Element {
 	_defaultSideCollapsed = isPhone() || (isTablet() && !isCombi());
 
 	/**
-	 * Specifies the navigation mode.
+	 * Specifies the navigation layout mode.
 	 * @default "Auto"
 	 * @public
 	 */

diff --git a/packages/fiori/src/types/NavigationLayoutMode.ts b/packages/fiori/src/types/NavigationLayoutMode.ts
@@ -4,18 +4,18 @@
  */
 enum NavigationLayoutMode {
 	/**
-	 * Automatically calculates the collapsed mode based on the screen device type.
+	 * Automatically calculates the navigation layout mode based on the screen device type.
 	 * `Expanded` on desktop and `Collapsed` on tablet and phone.
 	 * @public
 	 */
 	Auto = "Auto",
 	/**
-	 * Collapsed
+	 * Collapsed side navigation.
 	 * @public
 	 */
 	Collapsed = "Collapsed",
 	/**
-	 * Expanded
+	 * Expanded side navigation.
 	 * @public
 	 */
 	Expanded = "Expanded",

diff --git a/packages/website/docs/_samples/fiori/NavigationLayout/Basic/main.js b/packages/website/docs/_samples/fiori/NavigationLayout/Basic/main.js
@@ -25,8 +25,10 @@ import "@ui5/webcomponents-icons/dist/document-text.js";
 import "@ui5/webcomponents-icons/dist/compare.js";
 import "@ui5/webcomponents-icons/dist/locked.js";
 
+import NavigationLayoutMode from "@ui5/webcomponents-fiori/dist/types/NavigationLayoutMode.js";
+
 document.querySelector("#startButton").addEventListener("click", function (event) {
-	nl1.mode = nl1.isSideCollapsed() ? "Expanded" : "Collapsed";
+	nl1.mode = nl1.isSideCollapsed() ? NavigationLayoutMode.Expanded : NavigationLayoutMode.Collapsed;
 });
 
 document.querySelector("#sn1").addEventListener("selection-change", function (event) {