Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect deprecated 'type' in View.create / <mvc:View> #475

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jan 10, 2025

This adds the detection of the partial deprecation of the View.create factory.

In addition, nested views within XML that use the general mvc:View tag are now also detected when using a deprecated 'type'.

JIRA: CPOUI5FOUNDATION-907

This adds the detection of the partial deprecation of the View.create
factory.

In addition, nested views within XML that use the general <mvc:View>
tag are now also detected when using a deprecated 'type'.

JIRA: CPOUI5FOUNDATION-907
@matz3 matz3 force-pushed the detect-view-create-type-deprecation branch from 816ed8f to 38eef73 Compare January 13, 2025 09:42
@matz3 matz3 requested a review from a team January 14, 2025 08:41
Copy link
Contributor

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 requested a review from a team January 14, 2025 09:22
@matz3 matz3 merged commit 14667aa into main Jan 14, 2025
13 checks passed
@matz3 matz3 deleted the detect-view-create-type-deprecation branch January 14, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants