Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect usage of non exported values by library.js #468

Merged
merged 25 commits into from
Jan 14, 2025
Merged

feat: Detect usage of non exported values by library.js #468

merged 25 commits into from
Jan 14, 2025

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-957

@d3xter666 d3xter666 marked this pull request as draft January 9, 2025 09:31
@d3xter666 d3xter666 marked this pull request as ready for review January 9, 2025 13:18
@d3xter666 d3xter666 requested a review from KlattG January 9, 2025 13:18
@d3xter666
Copy link
Contributor Author

Hi @KlattG ,

Would you take a look at the new messages in here, please?
https://github.com/SAP/ui5-linter/pull/468/files#diff-09701c0232493655601b38f00fc2ebafebdf513a2aaf652ef5d440d1ea3ee04dR575

@d3xter666 d3xter666 requested a review from a team January 9, 2025 13:20
KlattG
KlattG approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matz3
matz3 reviewed Jan 9, 2025
View reviewed changes
src/linter/ui5Types/SourceFileLinter.ts Outdated Show resolved Hide resolved
src/linter/ui5Types/SourceFileLinter.ts Outdated Show resolved Hide resolved
@d3xter666 d3xter666 force-pushed the feat-libjs-non-exported-values branch from 0e40a22 to 8bb9d55 Compare January 10, 2025 08:31
@d3xter666 d3xter666 requested a review from matz3 January 10, 2025 10:30
@d3xter666
Copy link
Contributor Author

Hi @KlattG ,

Would you take a look again, please?
https://github.com/SAP/ui5-linter/pull/468/files#diff-09701c0232493655601b38f00fc2ebafebdf513a2aaf652ef5d440d1ea3ee04dR579

Here's an example produced message:
https://github.com/SAP/ui5-linter/pull/468/files#diff-f32c91d608e9b3542dbe158a009067f34d4ccdc04b59ab81039bcb497db55703R21

Cheers

@d3xter666 d3xter666 requested review from matz3 and KlattG January 10, 2025 13:20
@d3xter666 d3xter666 requested a review from matz3 January 10, 2025 17:16
KlattG
KlattG approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matz3
matz3 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/fixtures/linter/rules/NoGlobals/NoExportedLibValues_Negative.js
"sap/ui/core/library",
// This ones are correct- elements, imported as modules
"sap/ui/unified/DateTypeRange",
"sap/ui/unified/CalendarDayType",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a pseudo module (see finding in test snapshot), and it should rather be accessed via the library module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, and that's why I added it. With the prevous miss, actually the pseudo modules were also reported as non exported values. Let's leave this as a safeguard.

@matz3 matz3 requested a review from a team January 13, 2025 08:01
@d3xter666 d3xter666 merged commit be2cbb7 into main Jan 14, 2025
13 checks passed
@d3xter666 d3xter666 deleted the feat-libjs-non-exported-values branch January 14, 2025 12:17
@openui5bot openui5bot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG approved these changes

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3xter666 @matz3 @KlattG