Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Test CodeQL PR #963

Closed
wants to merge 1 commit into from
Closed

[INTERNAL] Test CodeQL PR #963

wants to merge 1 commit into from

Conversation

d3xter666
Copy link
Contributor

This chnage "reverts" #958 in order to check whether CodeQL would fail the build and respectively block the merge

@d3xter666 d3xter666 changed the title Test CodeQL PR [INTERNAL] Test CodeQL PR Nov 30, 2023
@@ -12,7 +12,7 @@
if ( !type.startsWith(".") ) {
type = "." + type;
}
return type.replace(/[*+?.()|^$\\]/g, "\\$&");
return type.replace(/[*+?.()|^$]/g, "\\$&");

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This does not escape backslash characters in the input.
@d3xter666
Copy link
Contributor Author

This was just a check. It was successful, so closing the PR

@d3xter666 d3xter666 closed this Nov 30, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.444%. remained the same
when pulling 230d332 on test-codeql
into d61f1b7 on main.

@flovogt flovogt deleted the test-codeql branch November 30, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants