fix eslint issues

SAP · Nov 29, 2023 · a9077ac · a9077ac
1 parent 33b4138
commit a9077ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/processors/manifestTransformer.js b/lib/processors/manifestTransformer.js
@@ -24,7 +24,7 @@ function getLocale(name) {
  * @returns {boolean}
  */
 function hasManifestTemplates(manifest) {
-	const rManifestTemplate = /\{\{([^\}\}]+)\}\}/g;
+	const rManifestTemplate = /\{\{([^}}]+)\}\}/g;
 	return JSON.stringify(manifest).match(rManifestTemplate);
 }
 
@@ -180,7 +180,8 @@ async function transformManifest(resource, fs, options) {
 				"properties file for defined fallbackLocale or configure another available fallbackLocale");
 			return;
 		} else if (!fallbackLocale && !isFallbackLocalePartOfSupportedLocales("en", generatedSupportedLocales)) {
-			// TO DECIDE: in case no fallbacklocale is defined "en" is used. Should we generate supportedLocales in that case?
+			// TO DECIDE: in case no fallbacklocale is defined locale "en" is used.
+			// Should we generate supportedLocales in that case?
 			log.warn("manifest.json: Generated supported locales ('" + generatedSupportedLocales.join("', '") + "') " +
 				"do not contain default fallback locale 'en'. Either provide a " +
 				"properties file for 'en' or configure another available fallbackLocale");

diff --git a/lib/tasks/transformManifest.js b/lib/tasks/transformManifest.js
@@ -1,17 +1,18 @@
-import { getLogger } from "@ui5/logger";
-const log = getLogger("builder:tasks:transformManifest");
 import manifestTransformer from "../processors/manifestTransformer.js";
 import fsInterface from "@ui5/fs/fsInterface";
 
+/* eslint "jsdoc/check-param-names": ["error", {"disableExtraPropertyReporting":true}] */
 /**
  * Task for transforming the manifest.json file.
  *
- * @module builder/tasks/transformManifest
+ * @public
+ * @function default
+ * @static
  *
  * @param {object} parameters Parameters
  * @param {@ui5/fs/DuplexCollection} parameters.workspace DuplexCollection to read and write files
  * @param {object} parameters.options Options
- * @param {string} parameters.options.projectNamespace Namespace of the project
+ * @param {string} parameters.options.projectNamespace Namespace of the application
  * @returns {Promise<undefined>} Promise resolving with <code>undefined</code> once data has been written
  */
 export default async function({workspace, options}) {