generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(preview-middleware-client): dialog and manifest change quick acti…
…ons (#2722) * fix: dialog and manifest change quick actions * chore: remove unused code * chore: add changeset * refactor: remove code duplication * chore: fix sonar issue * refactor: don't ignore eslint rule * chore: update changeset * chore: fix formatting
- Loading branch information
Showing
37 changed files
with
1,159 additions
and
468 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@sap-ux-private/preview-middleware-client': patch | ||
| '@sap-ux/control-property-editor': patch | ||
| '@sap-ux/preview-middleware': patch | ||
| --- | ||
|
|
||
| Fixed Quick Actions not working after trying to open multiple dialogs and Quick Actions that create manifest changes in SAP Fiori Elements for OData V2 applications not showing correct state when there are unsaved manifest changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
packages/preview-middleware-client/src/adp/dialog-factory.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| import Dialog from 'sap/m/Dialog'; | ||
| import UI5Element from 'sap/ui/core/Element'; | ||
| import Fragment from 'sap/ui/core/Fragment'; | ||
| import RuntimeAuthoring from 'sap/ui/rta/RuntimeAuthoring'; | ||
|
|
||
| import { getTextBundle } from '../i18n'; | ||
|
|
||
| import AddFragment, { AddFragmentOptions } from './controllers/AddFragment.controller'; | ||
| import AddTableColumnFragments from './controllers/AddTableColumnFragments.controller'; | ||
| import ControllerExtension from './controllers/ControllerExtension.controller'; | ||
| import ExtensionPoint from './controllers/ExtensionPoint.controller'; | ||
|
|
||
| import { ExtensionPointData } from './extension-point'; | ||
|
|
||
| export const enum DialogNames { | ||
| ADD_FRAGMENT = 'AddFragment', | ||
| ADD_TABLE_COLUMN_FRAGMENTS = 'AddTableColumnFragments', | ||
| CONTROLLER_EXTENSION = 'ControllerExtension', | ||
| ADD_FRAGMENT_AT_EXTENSION_POINT = 'ExtensionPoint' | ||
| } | ||
|
|
||
| type Controller = AddFragment | AddTableColumnFragments | ControllerExtension | ExtensionPoint; | ||
|
|
||
| export const OPEN_DIALOG_STATUS_CHANGED = 'OPEN_DIALOG_STATUS_CHANGED'; | ||
|
|
||
| export class DialogFactory { | ||
| private static readonly eventTarget = new EventTarget(); | ||
| private static isDialogOpen = false; | ||
| /** | ||
| * Only one dialog can be open at a time. This flag indicates if a new dialog can be opened. | ||
| */ | ||
|
|
||
| public static get canOpenDialog(): boolean { | ||
| return !this.isDialogOpen; | ||
| } | ||
|
|
||
| /** | ||
| * Factory method for creating a new dialog. | ||
| * | ||
| * @param overlay - Control overlay. | ||
| * @param rta - Runtime Authoring instance. | ||
| * @param dialogName - Dialog name. | ||
| * @param extensionPointData - Control ID. | ||
| * @param options - Dialog options. | ||
| */ | ||
| public static async createDialog( | ||
| overlay: UI5Element, | ||
| rta: RuntimeAuthoring, | ||
| dialogName: DialogNames, | ||
| extensionPointData?: ExtensionPointData, | ||
| options: Partial<AddFragmentOptions> = {} | ||
| ): Promise<void> { | ||
| if (this.isDialogOpen) { | ||
| return; | ||
| } | ||
| let controller: Controller; | ||
| const resources = await getTextBundle(); | ||
|
|
||
| switch (dialogName) { | ||
| case DialogNames.ADD_FRAGMENT: | ||
| controller = new AddFragment(`open.ux.preview.client.adp.controllers.${dialogName}`, overlay, rta, { | ||
| aggregation: options.aggregation, | ||
| title: resources.getText(options.title ?? 'ADP_ADD_FRAGMENT_DIALOG_TITLE') | ||
| }); | ||
| break; | ||
| case DialogNames.ADD_TABLE_COLUMN_FRAGMENTS: | ||
| controller = new AddTableColumnFragments( | ||
| `open.ux.preview.client.adp.controllers.${dialogName}`, | ||
| overlay, | ||
| rta, | ||
| { | ||
| aggregation: options.aggregation, | ||
| title: resources.getText(options.title ?? 'ADP_ADD_FRAGMENT_DIALOG_TITLE') | ||
| } | ||
| ); | ||
| break; | ||
| case DialogNames.CONTROLLER_EXTENSION: | ||
| controller = new ControllerExtension( | ||
| `open.ux.preview.client.adp.controllers.${dialogName}`, | ||
| overlay, | ||
| rta | ||
| ); | ||
| break; | ||
| case DialogNames.ADD_FRAGMENT_AT_EXTENSION_POINT: | ||
| controller = new ExtensionPoint( | ||
| `open.ux.preview.client.adp.controllers.${dialogName}`, | ||
| overlay, | ||
| rta, | ||
| extensionPointData! | ||
| ); | ||
| break; | ||
| } | ||
|
|
||
| const id = dialogName === DialogNames.ADD_FRAGMENT_AT_EXTENSION_POINT ? `dialog--${dialogName}` : undefined; | ||
|
|
||
| const dialog = (await Fragment.load({ | ||
| name: `open.ux.preview.client.adp.ui.${dialogName}`, | ||
| controller, | ||
| id | ||
| })) as Dialog; | ||
|
|
||
| this.isDialogOpen = true; | ||
| dialog.attachBeforeClose(() => { | ||
| this.updateStatus(false); | ||
| }); | ||
|
|
||
| await controller.setup(dialog); | ||
| this.updateStatus(true); | ||
| } | ||
|
|
||
| /** | ||
| * Updates open dialog status. | ||
| * | ||
| * @param isDialogOpen Flag indicating if there is an open dialog. | ||
| */ | ||
| private static updateStatus(isDialogOpen: boolean) { | ||
| this.isDialogOpen = isDialogOpen; | ||
| const event = new CustomEvent(OPEN_DIALOG_STATUS_CHANGED); | ||
| this.eventTarget.dispatchEvent(event); | ||
| } | ||
|
|
||
| /** | ||
| * Attach event handler for OPEN_DIALOG_STATUS_CHANGED event. | ||
| * | ||
| * @param handler Event handler. | ||
| * @returns Function that removes listener. | ||
| */ | ||
| public static onOpenDialogStatusChange(handler: (event: CustomEvent) => void | Promise<void>): () => void { | ||
| this.eventTarget.addEventListener(OPEN_DIALOG_STATUS_CHANGED, handler as EventListener); | ||
| return () => { | ||
| this.eventTarget.removeEventListener(OPEN_DIALOG_STATUS_CHANGED, handler as EventListener); | ||
| }; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.