Fixed 2 integration tests #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
he-is-harry
commented
Jan 10, 2025
he-is-harry
commented
- In HANA Cloud, SQL used in the 'createReadNumbersProc' testing setup is not supported, so the SQL was changed when run on HANA cloud.
- Also modified 'direct execute of ProcView with parameters' test to match the new change above for HANA cloud.
- Also updated 'should return all numbers like `b`' test metadata data type to match those from the HANA database.
- When not running on HANA cloud, the behaviour and SQL executed is the same as before.
- Fixed SQL input which is not available in HANA cloud in the createReadNumbersProc testing setup function. - Also modified 'direct execute of ProcView with parameters' test to match the new change above for HANA cloud. - When not running on HANA cloud, the behavior is the same as before.
|
|
- Updated tests to consider versions starting with "4." as HANA cloud rather than "4.5"
IanMcCurdy
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.