Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): update Notifications doc examples #13003

Merged
merged 1 commit into from
Feb 6, 2025

docs(core): update Notifications doc examples

bd06e26
Select commit
Loading
Failed to load commit list.
Merged

docs(core): update Notifications doc examples #13003

docs(core): update Notifications doc examples
bd06e26
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Feb 3, 2025 in 2s

1/3 Fail(s): APPROVALS

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must exclude '^[WIP]'
    Input : docs(core): update Notifications doc examples
    Settings : {"must_exclude":{"regex":"^\\[WIP\\]","message":"This is work in progress. Do not merge yet."}}
  • ✔️ title must include '^(feat|docs|chore|fix|test)((\w+))?(:|().+$'
    Input : docs(core): update Notifications doc examples
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|test)(\\(\\w+\\))?(:|\\().+$","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '[ ]'
    Input : ## Related Issue(s)

closes none

Description

  • Import Title component as the CSS wasn't coming
  • update the settings icon
    Settings : {"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}

❌ Validator: APPROVALS

  • (approvals: InnaAtanasova required OR approvals: droshev required OR approvals: dpavlenishvili required OR approvals: mikerodonnell89 required OR approvals count is less than "2")
    Input :
    Settings : {"or":[{"required":{"reviewers":["InnaAtanasova"]}},{"required":{"reviewers":["droshev"]}},{"required":{"reviewers":["dpavlenishvili"]}},{"required":{"reviewers":["mikerodonnell89"]}},{"min":{"count":2}}]}