Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): table multi-select checkbox a11y improvements #12962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/core/checkbox/checkbox/checkbox.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
[checked]="isChecked"
[attr.tabindex]="tabIndexValue"
[attr.role]="role"
[attr.aria-checked]="isChecked"
[attr.aria-checked]="isChecked ? 'true' : isIndeterminate ? 'mixed' : 'false'"
[attr.aria-label]="ariaLabel"
[attr.aria-labelledby]="ariaLabelledBy"
[attr.aria-describedby]="ariaDescribedBy"
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/models/fd-language-key-identifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,9 @@ export type FdLanguageKeyIdentifier =
| 'platformTable.sortDialogCancelBtnLabel'
| 'platformTable.selectAllCheckboxLabel'
| 'platformTable.deselectAllCheckboxLabel'
| 'platformTable.selectAllCheckboxLongLabel'
| 'platformTable.selectAllCheckboxMixedLongLabel'
| 'platformTable.deselectAllCheckboxLongLabel'
| 'platformTable.deselectSingleRow'
| 'platformTable.selectSingleRow'
| 'platformTable.loadMore'
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/models/fd-language.ts
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ export interface FdLanguage {
sortDialogCancelBtnLabel: FdLanguageKey;
selectAllCheckboxLabel: FdLanguageKey;
deselectAllCheckboxLabel: FdLanguageKey;
deselectAllCheckboxLongLabel: FdLanguageKey;
selectAllCheckboxLongLabel: FdLanguageKey;
selectAllCheckboxMixedLongLabel: FdLanguageKey;
deselectSingleRow: FdLanguageKey;
selectSingleRow: FdLanguageKey;
showingBlankOfBlank: FdLanguageKey;
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations.properties
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,12 @@ platformTable.sortDialogCancelBtnLabel = Cancel
platformTable.selectAllCheckboxLabel = Select all
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel = Deselect all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow = To deselect row, press SPACEBAR
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,9 @@ export default {
sortDialogCancelBtnLabel: 'Cancel',
selectAllCheckboxLabel: 'Select all',
deselectAllCheckboxLabel: 'Deselect all',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'To deselect row, press SPACEBAR',
selectSingleRow: 'To select row, press SPACEBAR',
loadMore: 'Show more',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_ar.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=إلغاء
platformTable.selectAllCheckboxLabel=تحديد الكل
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=إلغاء تحديد الكل
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=لإلغاء تحديد الصف، اضغط مفتاح المسافة
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_ar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ export default {
sortDialogCancelBtnLabel: 'إلغاء',
selectAllCheckboxLabel: 'تحديد الكل',
deselectAllCheckboxLabel: 'إلغاء تحديد الكل',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'لإلغاء تحديد الصف، اضغط مفتاح المسافة',
selectSingleRow: 'لتحديد الصف، اضغط مفتاح المسافة',
loadMore: 'تحميل المزيد',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_bg.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Отказ
platformTable.selectAllCheckboxLabel=Избиране на всички
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Отмяна на избора на всички
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=За премахване на ред от избраните, натиснете ИНТЕРВАЛ
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_bg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ export default {
sortDialogCancelBtnLabel: 'Отказ',
selectAllCheckboxLabel: 'Избиране на всички',
deselectAllCheckboxLabel: 'Отмяна на избора на всички',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'За премахване на ред от избраните, натиснете ИНТЕРВАЛ',
selectSingleRow: 'За избор на ред, натиснете ИНТЕРВАЛ',
loadMore: 'Зареждане на повече',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_cs.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Zrušit
platformTable.selectAllCheckboxLabel=Vybrat vše
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Zrušit celý výběr
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Výběr řádky zrušíte stisknutím mezerníku
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_cs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ export default {
sortDialogCancelBtnLabel: 'Zrušit',
selectAllCheckboxLabel: 'Vybrat vše',
deselectAllCheckboxLabel: 'Zrušit celý výběr',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Výběr řádky zrušíte stisknutím mezerníku',
selectSingleRow: 'Řádku vyberete stisknutím mezerníku',
loadMore: 'Načíst další',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_da.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Annuller
platformTable.selectAllCheckboxLabel=Vælg alle
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Fravælg alle
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Tryk på mellemrumstasten for at slette markering af række
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_da.ts
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ export default {
sortDialogCancelBtnLabel: 'Annuller',
selectAllCheckboxLabel: 'Vælg alle',
deselectAllCheckboxLabel: 'Fravælg alle',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Tryk på mellemrumstasten for at slette markering af række',
selectSingleRow: 'Tryk på mellemrumstasten for at vælge række',
loadMore: 'Indlæs mere',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_de.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Abbrechen
platformTable.selectAllCheckboxLabel=Alle auswählen
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Alle abwählen
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Um Zeilenauswahl aufzuheben, Leertaste drücken
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ export default {
sortDialogCancelBtnLabel: 'Abbrechen',
selectAllCheckboxLabel: 'Alle auswählen',
deselectAllCheckboxLabel: 'Alle abwählen',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Um Zeilenauswahl aufzuheben, Leertaste drücken',
selectSingleRow: 'Um Zeile auszuwählen, Leertaste drücken',
loadMore: 'Weitere laden',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_el.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Ακύρωση
platformTable.selectAllCheckboxLabel=Επιλογή όλων
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Κατάργηση επιλογής όλων
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Για να αποεπιλέξετε σειρά, πατήστε το ΚΕΝΟ ΔΙΑΣΤΗΜΑ
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_el.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ export default {
sortDialogCancelBtnLabel: 'Ακύρωση',
selectAllCheckboxLabel: 'Επιλογή όλων',
deselectAllCheckboxLabel: 'Κατάργηση επιλογής όλων',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Για να αποεπιλέξετε σειρά, πατήστε το ΚΕΝΟ ΔΙΑΣΤΗΜΑ',
selectSingleRow: 'Για να αποεπιλέξετε σειρά, πατήστε το ΚΕΝΟ ΔΙΑΣΤΗΜΑ',
loadMore: 'Φόρτωση περισσότερων',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,12 @@ platformTable.sortDialogCancelBtnLabel=[[[Ĉąŋċēĺ∙∙∙∙∙∙∙∙]]
platformTable.selectAllCheckboxLabel=[[[Ŝēĺēċţ ąĺĺ∙∙∙∙]]]
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=[[[Ďēşēĺēċţ ąĺĺ∙∙∙∙∙∙∙]]]
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=[[[Ţŏ ƌēşēĺēċţ ŗŏŵ, ρŗēşş ŜƤĀĈĔƁĀŘ∙∙∙∙∙∙∙∙∙∙]]]
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_en_US_sappsd.ts
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ export default {
sortDialogCancelBtnLabel: '[[[Ĉąŋċēĺ∙∙∙∙∙∙∙∙]]]',
selectAllCheckboxLabel: '[[[Ŝēĺēċţ ąĺĺ∙∙∙∙]]]',
deselectAllCheckboxLabel: '[[[Ďēşēĺēċţ ąĺĺ∙∙∙∙∙∙∙]]]',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: '[[[Ţŏ ƌēşēĺēċţ ŗŏŵ, ρŗēşş ŜƤĀĈĔƁĀŘ∙∙∙∙∙∙∙∙∙∙]]]',
selectSingleRow: '[[[Ţŏ şēĺēċţ ŗŏŵ, ρŗēşş ŜƤĀĈĔƁĀŘ∙∙∙∙∙∙∙∙∙]]]',
loadMore: '[[[Ļŏąƌ ɱŏŗē∙∙∙∙∙]]]',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_es.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Cancelar
platformTable.selectAllCheckboxLabel=Seleccionar todos
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Deseleccionar todo
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Pulse la barra de espaciado para anular la selección
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ export default {
sortDialogCancelBtnLabel: 'Cancelar',
selectAllCheckboxLabel: 'Seleccionar todos',
deselectAllCheckboxLabel: 'Deseleccionar todo',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Pulse la barra de espaciado para anular la selección',
selectSingleRow: 'Pulse la barra de espaciado para seleccionar líneas',
loadMore: 'Cargar más',
Expand Down
6 changes: 6 additions & 0 deletions libs/i18n/src/lib/translations/translations_fi.properties
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,12 @@ platformTable.sortDialogCancelBtnLabel=Peruuta
platformTable.selectAllCheckboxLabel=Valitse kaikki
#XFLD Label for the checkbox, which deselects all rows in the table
platformTable.deselectAllCheckboxLabel=Poista kaikki valinnat
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxLongLabel = Checkbox, unchecked, click to select all
#XACT Text for the mixed state checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.selectAllCheckboxMixedLongLabel = Checkbox, mixed, click to select all
#XACT Text for the checkbox, which selects all rows in the table, longer explanation for screen reader
platformTable.deselectAllCheckboxLongLabel = Checkbox, checked, click to deselect all
#XACT Text, which is read by screen reader, tells instruction of how to deselect a row
platformTable.deselectSingleRow=Poista rivin valinta painamalla välilyöntinäppäintä
#XACT Text, which is read by screen reader, tells instruction of how to select a row
Expand Down
3 changes: 3 additions & 0 deletions libs/i18n/src/lib/translations/translations_fi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ export default {
sortDialogCancelBtnLabel: 'Peruuta',
selectAllCheckboxLabel: 'Valitse kaikki',
deselectAllCheckboxLabel: 'Poista kaikki valinnat',
selectAllCheckboxLongLabel: 'Checkbox, unchecked, click to select all',
selectAllCheckboxMixedLongLabel: 'Checkbox, mixed, click to select all',
deselectAllCheckboxLongLabel: 'Checkbox, checked, click to deselect all',
deselectSingleRow: 'Poista rivin valinta painamalla välilyöntinäppäintä',
selectSingleRow: 'Valitse rivi painamalla välilyöntinäppäintä',
loadMore: 'Lataa enemmän',
Expand Down
Loading
Loading