feat(platform): add dropdown menu for predefined filter options #12859
Conversation
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
There was a problem hiding this comment.
@mohammad-nmeri Sorry, but before we can review, commit messages must adhere to these rules for release log generation purposes: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md#commit
mohammad-nmeri
changed the title
|
@mikerodonnell89, apologies for the oversight. I have updated the commit message |
There was a problem hiding this comment.
@mohammad-nmeri It looks like maybe you did not push your changes, as I'm seeing your commit message is still missing the prefix. Your commit message should be looking like your PR title. Also, I think your formatting would not pass our pre-commit lint rules. I think you may have somehow bypassed our pre-commit hooks. I'd do the following:
- Switch to the main branch, make sure you have the latest with
git pull, and runyarn install. This is to ensure you have the correct formatting rules. - Switch back to this branch
- Soft reset your changes with
git reset --soft HEAD~1 - Run
yarn nx formatfor your changed files. I.e.yarn nx format libs/docs/platform/table/examples/advanced-scrolling/advanced-scrolling-example.component.htmletc for each file - Commit with `git commit -m 'feat(platform): add dropdown menu for predefined filter options'
- Force push
And that should satisfy the comment rules and the formatting rules.
Description
This PR enhances the filtering dialog in the Platform App by adding a dropdown for selecting predefined filter options. It introduces a new filterValuesOptions attribute in the columns component, which expects a string array of predefined filter values to be sent when defining a column. These values will be displayed in the filter dropdown, improving the filtering experience. Additionally, a new "Array" data type for columns is implemented to support this functionality.
Screenshots
Before:
After: