fix(core): handle IME input correctly to prevent accidental deletion of characters #12339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of characters closes [#12232](#12232) ## Description - Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese). - Introduced `isComposing` flag to bypass autocomplete logic during IME composition. - Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value. - Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 49d26e9): https://fundamental-ngx-gh--pr12339-fix-core-combobox-s-jjv211s8.web.app (expires Mon, 02 Sep 2024 13:12:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): handle IME input correctly to prevent accidental deletion of characters
closes #12232
Description
compositionstartandcompositionendevents to properly manage IME input (e.g., Chinese, Japanese).isComposingflag to bypass autocomplete logic during IME composition.inputTextsynchronization after IME input ends to ensure it matches the finalized value.