Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): fixed table row excessive focus and toggle handling #11000

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

g-cheishvili
Copy link
Contributor

Related Issue(s)

Part of the #10870 needs ng15 downport

Description

Removed automatically set focusability trait on the rows and moved expansion/collapse control to the space button instead of the arrow-right/arrow-left

@g-cheishvili g-cheishvili added accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support platform platform ariba to identify issues that belongs to ariba team table labels Nov 23, 2023
@g-cheishvili g-cheishvili added this to the Sprint 126 milestone Nov 23, 2023
@g-cheishvili g-cheishvili requested a review from a team November 23, 2023 21:34
Copy link

github-actions bot commented Nov 23, 2023

Visit the preview URL for this PR (updated for commit fa8e2ee):

https://fundamental-ngx-gh--pr11000-table-row-focus-ib3l70zm.web.app

(expires Thu, 30 Nov 2023 09:57:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit fa8e2ee
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/65646698675ee00008fce306
😎 Deploy Preview https://deploy-preview-11000--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@g-cheishvili g-cheishvili merged commit ac758bb into main Nov 27, 2023
17 of 18 checks passed
@g-cheishvili g-cheishvili deleted the table_row_focus branch November 27, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support ariba to identify issues that belongs to ariba team platform platform table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants