Skip to content

Commit

Permalink
fix(core): handle undefined case
Browse files Browse the repository at this point in the history
  • Loading branch information
itsnode authored and droshev committed Nov 30, 2023
1 parent f25543c commit 737fcf7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ChangeDetectionStrategy, Component, Input, ViewEncapsulation } from '@angular/core';
import { FD_SHELLBAR_ACTION_COMPONENT } from '../tokens';
import { Nullable } from '@fundamental-ngx/cdk/utils';

/**
* The component that represents a shellbar action.
Expand Down Expand Up @@ -48,9 +49,9 @@ export class ShellbarActionComponent {

/** title of the action button. */
@Input()
title: string;
title: Nullable<string>;

/** aria-label of the action button */
@Input()
ariaLabel: string;
ariaLabel: Nullable<string>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class ShellbarCollapsibleExampleComponent {
label: 'Pool',
title: 'Pool',
ariaLabel: 'Pool',
notificationCount: 3,
notificationCount: 0,
notificationLabel: 'Pool Count'
},
{
Expand Down

0 comments on commit 737fcf7

Please sign in to comment.