Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt docs for phase 2 of tenant-wide secrets #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

marc-niemella
Copy link

No description provided.

Copy link

cla-assistant bot commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines +51 to +64
### Get Secret:
The response contains the name, and the creation timestamp of the requested generic secrets. No sensitive information is revealed in the response.
In the case of a tenant-wide secret, the response also includes a list of all resource groups associated with the tenant and the current replication status of the secret to these resource groups.

```
# Example response for a tenant-wide secret
{
"name": "secret-1",
"createdAt": "<timestamp>",
"resourceGroupSecretReplicationStatus":{
"rg-id-1" : true, # secret was replicated correctly in this namespace
"rg-id-2" : false, # secret was not replicated or does not exist in this namespace yet
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming the resourceGroupSecretReplicationStatus field is present in the response body only when the headers set the scope to tenant-wide level.
Can this be made explicit here?

{
"name": "secret-1",
"createdAt": "<timestamp>",
"resourceGroupSecretReplicationStatus":{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see above comment on resourceGroupSecretReplicationStatus

> In order to allow rotation of Tenant-Wide secrets for long-running deployments without restarting the deployment, the following guidelines must be followed:
> - The deployment MUST mount the Tenant-Wide secret. For more information see [Consume a Generic Secret as a Volume Mount](consume-generic-secrets-in-executions-or-deployments-185a324.md)
> - The deployment MUST monitor the mounted secret for changes instead of relying on an in-memory copy of the secret read from the mount.
> - When a Tenant-Wide secret is updated, the tenant is responsible for observing the response of /secrets/{secret-name} endpoint to ensure that the Replicator has successfully updated the secret in all resource groups.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mention here that the tenant has to observe the resourceGroupSecretReplicationStatus field to ensure that the replication is successful in all RG namespace? Possibly also add a hyperlink to that page?

> In order to allow rotation of Tenant-Wide secrets for long-running deployments without restarting the deployment, the following guidelines must be followed:
> - The deployment MUST mount the Tenant-Wide secret. For more information see [Consume a Generic Secret as a Volume Mount](consume-generic-secrets-in-executions-or-deployments-185a324.md)
> - The deployment MUST monitor the mounted secret for changes instead of relying on an in-memory copy of the secret read from the mount.
> - When a Tenant-Wide secret is updated, the tenant is responsible for observing the response of /secrets/{secret-name} endpoint to ensure that the Replicator has successfully updated the secret in all resource groups.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment about adding explanation and hyperlink from the create-a-generic-secret page.

Comment on lines +87 to +91
> ### Note:
> In order to allow rotation of Tenant-Wide secrets for long-running deployments without restarting the deployment, the following guidelines must be followed:
> - The deployment MUST mount the Tenant-Wide secret. For more information see [Consume a Generic Secret as a Volume Mount](consume-generic-secrets-in-executions-or-deployments-185a324.md)
> - The deployment MUST monitor the mounted secret for changes instead of relying on an in-memory copy of the secret read from the mount.
> - When a Tenant-Wide secret is updated, the tenant is responsible for observing the response of /secrets/{secret-name} endpoint to ensure that the Replicator has successfully updated the secret in all resource groups.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note was already added to this page a few sections above. Are we intentionally repeating it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants