Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smart humidity helper based on error/bug thrown #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update smart humidity helper based on error/bug thrown #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions smartapps/sandood/ecobee-suite-smart-humidity.src/ecobee-suite-smart-humidity.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,21 +630,22 @@ def myConvertTemperatureIfNeeded(scaledSensorValue, cmdScale, precision) {
if (cmdScale == temperatureScale) {
return roundIt(scaledSensorValue, precision)
} else if (cmdScale == 'F') {
return roundIt(fToC(scaledSensorValue), precision)
return roundIt(fToC(scaledSensorValue.toBigDecimal()), precision)
} else {
return roundIt(cToF(scaledSensorValue), precision)
// PR NOTE: I'm not able to test this it seems, but I'm assuming the same conversion is required here as well
return roundIt(cToF(scaledSensorValue.toBigDecimal()), precision)
}
}
// Calculate a close approximation of Dewpoint based on Temperature & Relative Humidity
// TD: =243.04*(LN(RH/100)+((17.625*T)/(243.04+T)))/(17.625-LN(RH/100)-((17.625*T)/(243.04+T)))
def calculateDewpoint( temp, rh, units) {
def calculateDewpoint( BigDecimal temp, rh, units) {
def t = ((units == 'C') ? temp : fToC(temp)) as BigDecimal
def dpC = 243.04*(Math.log(rh/100.0)+((17.625*t)/(243.04+t)))/(17.625-Math.log(rh/100.0)-((17.625*t)/(243.04+t)))
return (units == 'C') ? roundIt(dpC, 2) : roundIt(cToF(dpC), 1)
}
// Calculate a close approximation of Relative Humidity based on Temperature and Dewpoint
// RH: =100*(EXP((17.625*TD)/(243.04+TD))/EXP((17.625*T)/(243.04+T)))
def calculateRelHumidity( temp, dp, units) {
def calculateRelHumidity( BigDecimal temp, dp, units) {
def t = ((units == 'C') ? temp : fToC(temp)) as BigDecimal
def td = ((units == 'C') ? dp : fToC(dp)) as BigDecimal
def rh = 100*((Math.exp((17.625*td)/(243.04+td)))/(Math.exp((17.625*t)/(243.04+t))))
Expand All @@ -656,11 +657,11 @@ def roundIt( value, decimals=0 ) {
def roundIt( BigDecimal value, decimals=0) {
return (value == null) ? null : value.setScale(decimals, BigDecimal.ROUND_HALF_DOWN)
}
def cToF(temp) {
def cToF(BigDecimal temp) {
return (temp != null) ? ((temp * 1.8) + 32) : null
}
def fToC(temp) {
return (temp != null) ? ((temp - 32) / 1.8) : null
def fToC(BigDecimal temp) {
return (temp != null) ? ((temp - 32) / 1.8) : null
}
void LOG(message, level=3, child=null, logType="debug", event=true, displayEvent=true) {
switch (logType) {
Expand Down