Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest classes cannot have an __init__ method #367

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jeremyestein
Copy link
Contributor

Several tests were being ignored in the system test.

@jeremyestein jeremyestein requested a review from a team April 10, 2024 14:27
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha yep that'd do it, frustrating that pytest fails silently here

@jeremyestein
Copy link
Contributor Author

Ha yep that'd do it, frustrating that pytest fails silently here

One reason I'd like to do some mutation testing one day! If you change a load of your code and your tests still pass, your tests are probably broken.
A more down to earth measure might be to track test coverage over time so we can investigate any sudden drops.

@jeremyestein jeremyestein merged commit 8270192 into main Apr 10, 2024
8 checks passed
@jeremyestein jeremyestein deleted the jeremy/fix-system-test-class branch April 10, 2024 14:48
@milanmlft
Copy link
Member

milanmlft commented Apr 11, 2024

A more down to earth measure might be to track test coverage over time so we can investigate any sudden drops.

Maybe worth adding to #331? -> #369

Also, sorry for this! This was part of fixing the mypy errors for #350, but did not realise the tests were failing 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants