Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] таблет #1005

Merged
merged 8 commits into from
Jan 25, 2025
Merged

[Balance] таблет #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8fde12a
tablet
nomad0260 Jan 15, 2025
d816f29
выживач
nomad0260 Jan 15, 2025
2b15ed3
Revert "tablet"
nomad0260 Jan 15, 2025
f6bda9d
votes
nomad0260 Jan 15, 2025
c94c756
cvars
nomad0260 Jan 16, 2025
78af74a
Squashed commit of the following:
nomad0260 Jan 17, 2025
49d5f09
Revert "Squashed commit of the following:"
nomad0260 Jan 19, 2025
65948c0
Merge branch 'tablet' of https://github.com/nomad0260/space-station-1…
nomad0260 Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Resources/ConfigPresets/Backmen/main.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ enabled=true
[laying]
crawlundertables=true

[vote]
map_enabled = true
restart_required_ratio = 0.6
timermap = 60
Comment on lines +147 to +150
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Рекомендации по улучшению конфигурации голосования

Текущая конфигурация может быть улучшена следующим образом:

  1. Значение timermap = 60 может быть недостаточным для сервера с 70 игроками. Рекомендуется увеличить до 120-180 секунд.
  2. Отсутствует минимальное количество голосов для принятия решения.
  3. Нет параметра задержки между голосованиями.

Предлагаю добавить следующие параметры:

 [vote]
 map_enabled = true
 restart_required_ratio = 0.6
-timermap = 60
+timermap = 180
+min_votes_required = 10
+vote_cooldown = 300
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[vote]
map_enabled = true
restart_required_ratio = 0.6
timermap = 60
[vote]
map_enabled = true
restart_required_ratio = 0.6
timermap = 180
min_votes_required = 10
vote_cooldown = 300


[hub]
advertise = true
tags = "lang:ru,region:eu_e,rp:med"
tags = "lang:ru,region:eu_e,rp:med"
8 changes: 8 additions & 0 deletions Resources/Prototypes/Loadouts/Miscellaneous/survival.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
- Moth
- Reptilian
- Vulpkanin # Corvax-MRP
#backmen-species-start
- ArachneClassic
- Felinid
- HumanoidFoxes
- Harpy
- Oni
- Shadowkin
#backmen-species-end

- type: loadoutEffectGroup
id: EffectSpeciesVox
Expand Down
4 changes: 2 additions & 2 deletions Resources/Prototypes/_Backmen/game_presets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
- bloodsucker
name: vampires-title
description: vampires-description
showInVote: true
showInVote: false # secret
rules:
- VampiresGameRule
- BasicStationEventScheduler
Expand Down Expand Up @@ -324,7 +324,7 @@
name: babelTower-title
description: babelTower-description
minPlayers: 5
showInVote: true
showInVote: false # secret
rules:
- BabelTower
- CalmStationEventScheduler
Expand Down
Loading