Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated man pages to make searching of long options compatible with more browsers #687

Closed

Conversation

purplearmadillo77
Copy link

I think this fixes #686. The NON_SPACE_SINGLE_DASH_RE regular expression was matching non-word followed by dash ((^|\W)-) rather than what the variable name suggests.

Copy link

@farshadjanu1 farshadjanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@WayneD
Copy link
Member

WayneD commented Jan 15, 2025

This transforms all hyphenated words, not just long options. So, no hyphenated words would be breakable.

Convert the interior dashes on long options.
@WayneD
Copy link
Member

WayneD commented Jan 15, 2025

I tweaked the script with a new regex that should handle this issue in long options while leaving hyphenated words alone.

@WayneD WayneD changed the title Fix NON_SPACE_SINGLE_DASH_RE to match single dashes after non-spaces. Fix generated man pages to make searching of long options compatible with more browsers Jan 15, 2025
@WayneD
Copy link
Member

WayneD commented Jan 16, 2025

I committed my change after making a regex improvement.

@WayneD WayneD closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain hyphenated options on rsync manual page are unsearchable
3 participants