Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dreden files RPG] - Migration to CSE + Small features #13706

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

BE-Arbiter
Copy link
Contributor

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

  • Refactor with gulp to add modularity (smaller source files)
  • Migration to CSE
  • Added "Send to chat" feature for some fields that can be usefull to be send to chat.

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@NorWhal
Copy link
Contributor

NorWhal commented Jan 23, 2025

@BE-Arbiter, everything looks good here! We're going to extend @DaTedinator the courtesy of two weeks to review this since it's such a massive overhaul, but once that is up we will be merging it either way!

We'd request that you make a courtesy post in the forum to inform the community that this overhaul will be coming; it doesn't seem that there's going to be much change in the actual UX by just looking at the code, but it's still good to make them aware of it so they know where to report any issues that may arise!

@DaTedinator
Copy link
Contributor

Oh, I haven't been on Roll20 in a couple years; by all means, go for it. I'm glad the sheet is being updated! Thanks, @BE-Arbiter!

@BE-Arbiter
Copy link
Contributor Author

@NorWhal Creating the post now.

@NorWhal
Copy link
Contributor

NorWhal commented Jan 28, 2025

Excellent, thanks so much gang!

@NorWhal NorWhal merged commit 8f23362 into Roll20:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants